Skip to content

Thrive search - no results update #4888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kkartunov opened this issue Sep 10, 2020 · 4 comments
Closed

Thrive search - no results update #4888

kkartunov opened this issue Sep 10, 2020 · 4 comments
Assignees
Labels
Contentful-DEV Internal development operations for Contentful QA Pass in PROD Passed verification on Production
Milestone

Comments

@kkartunov
Copy link
Collaborator

If a user types in something that we do not have, the dropdown should still appear with "no results".

However, if the user press the return button after their query, they should be taken to the search results page, which should display a message "No results found"

@kkartunov kkartunov self-assigned this Sep 10, 2020
@kkartunov kkartunov added the Contentful-DEV Internal development operations for Contentful label Sep 10, 2020
kkartunov added a commit that referenced this issue Sep 14, 2020
@kkartunov kkartunov added this to the By 9/15/2020 milestone Sep 14, 2020
@SathyaJayabal SathyaJayabal modified the milestones: By 9/15/2020, By 9/17/2020 Sep 14, 2020
@SathyaJayabal
Copy link
Collaborator

If a user types in something that we do not have, the dropdown appears with "no results".

However, if the user press the return button after their query, the search results page, with message message "No results found" is not displayed. The search results page keeps on loading.
Screenshot 2020-09-14 at 5 18 38 PM

@SathyaJayabal SathyaJayabal added QA Fail QA verification on Dev has failed. Assignee to redo the fix. QA Pass and removed Ready for QA QA Fail QA verification on Dev has failed. Assignee to redo the fix. labels Sep 14, 2020
@SathyaJayabal
Copy link
Collaborator

verified on staging
Screenshot 2020-09-14 at 6 27 06 PM

@sandhiyakavi
Copy link
Collaborator

Verified on staging.

image

image

sushilshinde added a commit that referenced this issue Sep 15, 2020
Title: Bug-fixes : v5 integration, cotentful, etc( Release - v1.2.1) (sushil)
Service & Impact Area: Community App
Expected Outcome: Fixes for MS https://github.com/topcoder-platform/community-app/milestone/55
Work plan: Issues: #2069 #4874 #4898 #4347 #4745 #4895 #4687 #4910 #4896 #4889 #4888 #4887 #4912
PR: #4923
DEPENDENCY: topcoder-react-lib
- Issue: #2069
- PR: topcoder-platform/topcoder-react-lib#253
DEPENDENCY: topcoder-react-ui-kit
- Issue: #4745
- PR: topcoder-archive/topcoder-platform-topcoder-react-ui-kit#35
Team: luiz/picachui/sandhiya/kiril/sushil
Date and Timing: Tue 15 Sept 2020, 4.00 PM
Testing (what will be tested): Fixes for MS https://github.com/topcoder-platform/community-app/milestone/55
Rollback Plan: Revert PR
@SathyaJayabal SathyaJayabal added QA Pass in PROD Passed verification on Production and removed QA Pass in Staging labels Sep 15, 2020
@SathyaJayabal
Copy link
Collaborator

verified on prod
Screenshot 2020-09-15 at 4 53 21 PM
Screenshot 2020-09-15 at 4 53 27 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contentful-DEV Internal development operations for Contentful QA Pass in PROD Passed verification on Production
Projects
None yet
Development

No branches or pull requests

3 participants