Skip to content

issue 4874 fix #4882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 13, 2020
Merged

issue 4874 fix #4882

merged 6 commits into from
Sep 13, 2020

Conversation

rashmi73
Copy link
Contributor

@rashmi73 rashmi73 commented Sep 9, 2020

No description provided.

@rashmi73 rashmi73 mentioned this pull request Sep 9, 2020
Closed
@luizrrodrigues luizrrodrigues requested review from luizrrodrigues and removed request for sushilshinde and ajefts September 10, 2020 01:34
luizrrodrigues
luizrrodrigues requested changes Sep 10, 2020
View reviewed changes
Copy link
Collaborator

@luizrrodrigues luizrrodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix test issue: Remove line 13
import localStorage from 'localStorage';

Also remove localStorage.setItem to trackStatus

Search for localStorage.setItem('trackStatus

@rashmi73
Copy link
Contributor Author

@luizrrodrigues fixing it

@luizrrodrigues luizrrodrigues self-requested a review September 13, 2020 21:00
@luizrrodrigues luizrrodrigues merged commit 2d6649a into topcoder-platform:milestone-20200917 Sep 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luizrrodrigues luizrrodrigues luizrrodrigues approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rashmi73 @luizrrodrigues