CLN: remove unnecessary _validate_foo methods #37106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noticed a minor typo when using the docs
* REF: extract func _select_upcast_cls_from_dtype * REF: extract function _get_upcast_classes * CLN: rename g -> common_dtype * TYP: type extracted functions * DOC: add docstrings to extracted methods * TYP: cast instead of ignoring mypy error * CLN: import SparseDtype only for type checking
…6647) * ENH: match stdlib behavior for datetimelike comparisons * update test Co-authored-by: Jeff Reback <[email protected]>
* CI: Update error message for np_dev * Comma * Fix
* #TST pandas-dev#13346 added tests * TST pandas-dev#13346 taken review into account * Added tests for pandas-dev#13346 - with review
…rs (pandas-dev#36746) * Standardize cast_str behavior in all datetimelike fill_value validators * CLN: remove cast_str kwarg
…ev#36840) * PERF: Index.equals when comparing to copies of self * refactor _shallow_copy, add GH number * PERF: share _cache, don't share _id * rename tests * fix memory usage test Co-authored-by: Jeff Reback <[email protected]>
jreback
added
Clean
Indexing
|
i guess the windows failures are spurious |
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Oct 26, 2020
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffsince DatetimeLike and Categorical no longer special-case these, we can inline them.