-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: Start v1.1.4 release notes #36689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Start v1.1.4 release notes #36689
Conversation
lgtm once v1.1.3 released. |
This can already be merged in master I think? (only the backport should only be merged after 1.1.3) |
don't merge. if merged web and docs will fail until tag available. |
@@ -73,4 +73,4 @@ Other | |||
Contributors | |||
~~~~~~~~~~~~ | |||
|
|||
.. contributors:: v1.1.2..v1.1.3|HEAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also remove this removal (and leave this for the actual release commits which also update the date etc), then it should pass?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's also a reference to v1.1.3 down below, should that also be removed, or do we wait for the tag?
Thanks @dsaxton |
Co-authored-by: Daniel Saxton <[email protected]>
I think this requires the v1.1.3 tag in order to pass