DOC: black enhancingperf.rst and 10min.rst code style #36849
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsaxton
reviewed
Oct 4, 2020
|
@BEANNAN If you add this to the flake8-rst ignore list in setup.cfg that should fix the lint error: |
I added it, but CI still seems to have some problems |
dsaxton
reviewed
Oct 4, 2020
| df | ||
| df.query('strings == "a" and nums == 1') | ||
| df.query("strings == "a" and nums == 1") |
There was a problem hiding this comment.
We need to use single quotes inside the double quotes
There was a problem hiding this comment.
doc ci seems to solve， but "pandas-dev.pandas (Linux py38_np_dev)" failed, Is this normal?
There was a problem hiding this comment.
That's unrelated, it's a flaky build
dsaxton
approved these changes
Oct 4, 2020
|
Thanks @BEANNAN |
jbrockmendel
pushed a commit
to jbrockmendel/pandas
that referenced
this pull request
Oct 13, 2020
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #36777