DOC: ran blacken docs tool and checked output to improve formatting #36777 #36802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @maria-ilie ! This looks correct, it's just that E203 needs to be added to the ignore list for [flake8-rst] Could you make the following change to diff --git a/setup.cfg b/setup.cfg
index 73986f692..eb2efb937 100644
--- a/setup.cfg
+++ b/setup.cfg
@@ -40,7 +40,9 @@ bootstrap =
np # avoiding error when importing again numpy or pandas
pd # (in some cases we want to do it to show users)
ignore = E402, # module level import not at top of file
+ E203, # space before : (needed for how black formats slicing)
W503, # line break before binary operator
+ W504, # line break after binary operator
# Classes/functions in different blocks can generate those errors
E302, # expected 2 blank lines, found 0
E305, # expected 2 blank lines after class or function definition, found 0(please do ask if you want/need help) |
|
Just to be sure we don't get any conflicts, I edited |
dsaxton
changed the title
|
Thanks @maria-ilie for the PR, can you merge master to fix the conflict? |
MarcoGorelli
suggested changes
Oct 4, 2020
Comment on lines
+670
to
+672
| df = pd.DataFrame( | ||
| {"id": [1, 2, 3, 4, 5, 6], "raw_grade": ["a", "b", "b", "a", "a", "e"]} | ||
| ) |
There was a problem hiding this comment.
Looks like this block got extra-indented by one space, this is causing the CI error, could you move it back?
dsaxton
approved these changes
Oct 4, 2020
Co-authored-by: Daniel Saxton <[email protected]>
|
Thanks @maria-ilie |
|
Thanks so much for reviewing! |
|
Happy to help, let us know if you'd like any help/mentoring with other issues |
jbrockmendel
pushed a commit
to jbrockmendel/pandas
that referenced
this pull request
Oct 13, 2020
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For task #36777
Ran blacken-tools on user_guide/10min.rst, user_guide/advanced.rst, basics.rst