Skip to content

ENH: match stdlib behavior for datetimelike comparisons #36647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 4, 2020
Merged

ENH: match stdlib behavior for datetimelike comparisons #36647

merged 5 commits into from
Oct 4, 2020

Conversation

jbrockmendel
Copy link
Member

@jreback jreback added Error Reporting Incorrect or improved errors from pandas Timezones Timezone data dtype labels Oct 2, 2020
@jreback jreback added this to the 1.2 milestone Oct 2, 2020
jreback
jreback approved these changes Oct 2, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ping on green.

@mroeschke mroeschke merged commit 7f87a03 into pandas-dev:master Oct 4, 2020
@mroeschke
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the compat-stdlib-tzcompare branch October 4, 2020 18:05
jbrockmendel added a commit to jbrockmendel/pandas that referenced this pull request Oct 13, 2020
@jbrockmendel @jreback
ENH: match stdlib behavior for datetimelike comparisons (pandas-dev#3…
74b7b41 
…6647)

* ENH: match stdlib behavior for datetimelike comparisons

* update test

Co-authored-by: Jeff Reback <[email protected]>
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
@jbrockmendel @jreback
ENH: match stdlib behavior for datetimelike comparisons (pandas-dev#3…
3a846ed 
…6647)

* ENH: match stdlib behavior for datetimelike comparisons

* update test

Co-authored-by: Jeff Reback <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Error Reporting Incorrect or improved errors from pandas Timezones Timezone data dtype
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.

COMPAT: tzawareness check behavior is different from stdlib
3 participants
@jbrockmendel @mroeschke @jreback