Standardize cast_str behavior in all datetimelike fill_value validators #36746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
added
Error Reporting
|
can you actually just remove this parameter entirely now? (e.g. its always true), or other cases? |
yes, planned for the next pr |
|
actually, since i need to rebase anyway, might as well now |
|
lgtm ping on green |
|
ping |
|
@jreback gentle ping; this is a blocker for long-awaited code de-duplication |
jbrockmendel
added a commit
to jbrockmendel/pandas
that referenced
this pull request
Oct 13, 2020
…rs (pandas-dev#36746) * Standardize cast_str behavior in all datetimelike fill_value validators * CLN: remove cast_str kwarg
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
…rs (pandas-dev#36746) * Standardize cast_str behavior in all datetimelike fill_value validators * CLN: remove cast_str kwarg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffThis will in turn allow us to simplify/de-duplicate a bunch of code since we now pass cast_str in all cases.