Skip to content

TST: Add test for operations on DataFrame with Interval CategoricalIndex #27443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 44 commits into from
Jul 23, 2019
Merged

TST: Add test for operations on DataFrame with Interval CategoricalIndex #27443

merged 44 commits into from
Jul 23, 2019

Conversation

another-green
Copy link
Contributor

@another-green another-green commented Jul 18, 2019 •
edited
Loading

another-green and others added 30 commits May 24, 2019 18:23
@another-green
BUG: None comparison evaluates to True pandas-dev#26504
e41387d
@ms7463 @another-green
ENH - Index set operation modifications to address issue pandas-dev#2…
9af03ce 
…3525 (pandas-dev#23538)
@simonjayhawkins @another-green
DOC/CLN: wil -> will (pandas-dev#26484)
620fa59
@javabrett @another-green
Fixed typo mutiplication -> multiplication. (pandas-dev#26489)
aad1bf9
@simonjayhawkins @another-green
DOC: fix SyntaxError in doc build on Windows (pandas-dev#26499)
ef87d02
@matsmaiwald @another-green
DOC: Highlighted role of index alignment in DataFrame.dot(other) (pan…
89cc7f2 
…das-dev#26480) (pandas-dev#26496)
@simonjayhawkins @another-green
DOC/CLN: Change API reference section title (pandas-dev#26486)
babd572
@topper-123 @another-green
CLN: Remove StringMixin from PandasObject (pandas-dev#26505)
4c231a7
@vaibhavhrt @another-green
Fix type annotations in pandas.core.indexes.datetimes (pandas-dev#26404)
cffbaac
@matsmaiwald @another-green
Better error message for DataFrame.hist() without numerical columns (… (
a8af7a1 
pandas-dev#26483)
@WillAyd @another-green
Excel Test Cleanup - ReadWriteClass (pandas-dev#26473)
ac02674
@mroeschke @another-green
CLN: pd.TimeGrouper (pandas-dev#26477)
9151211
@mroeschke @another-green
CLN: Remove ExcelWriter.sheetname (pandas-dev#26464)
8c8a175 
xref pandas-devgh-6581
@mroeschke @another-green
CLN: Remove deprecated parse_cols from read_excel (pandas-dev#26522)
9d6d959 
xref pandas-devgh-6581
@makbigc @another-green
[TEST] Add two more parameters to the test_dti_add_sub_nonzero_mth_of…
3bb4766 
…fset (pandas-dev#26392)

* Add two more parameters to the test

* Add array into the boy and add parameter freq
@nandahkrishna @another-green
Remove py.path special handling from io.common (pandas-dev#26458)
014abdc
@topper-123 @another-green
CLN: remove StringMixin from code base, except core.computation (pand…
420eee5 
…as-dev#26523)
@xcz011 @another-green
MAINT: port numpy#13188 for np_datetime simplification (pandas-dev#26516
48a4b8c 
)

* MAINT: port numpy#13188 for np_datetime simplificaion

Bring numpy changes about emulating the behavior of python's divmod to
pandas.

* cpplint fix

* Add reference numpy change into comment

* fix typo
@another-green
fix categorical comparison with missing values pandas-dev#26504
3e20569
@another-green
Merge branch 'master' into master
4d92eed
@another-green
Update test_operators.py
7e6662d
@another-green
Update categorical.py
16dac3a
@another-green
Update test_operators.py
9464f72
@another-green
Update test_operators.py
c2b7343
@another-green @jorisvandenbossche
Update doc/source/whatsnew/v0.25.0.rst
65014e7 
Co-Authored-By: Joris Van den Bossche <[email protected]>
@another-green
Update test_operators.py
8964f0a
@another-green
Update test_operators.py
7f404d2
@another-green
Update v0.25.0.rst
19e3711
@another-green
Update test_operators.py
2fc1d27
@another-green
Update test_operators.py
c80c2dc
@jschendel jschendel added Categorical Categorical Data Type DataFrame DataFrame data structure Interval Interval data type Testing pandas testing functions or related to the test suite labels Jul 18, 2019
jschendel
jschendel reviewed Jul 18, 2019
View reviewed changes
Copy link
Member

@jschendel jschendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think there's probably a better file to put these tests in but I'm not exactly sure where this should go. cc @jbrockmendel : do you have a preference on where this test should be moved to?

@jbrockmendel
Copy link
Member

Yah these definitely don't belong in tests.indexing. Is there anything DataFrame-specific about them, or could similar tests be written for Series etc? If the latter, then these would go in tests.arithmetic. If they are DataFrame-specific, then tests.frame.test_arithmetic

jreback
jreback requested changes Jul 20, 2019
View reviewed changes
@another-green another-green force-pushed the test_CategoricalIndex branch from c7c0135 to 7a5dac4 Compare July 20, 2019 22:37
@jreback jreback added this to the 1.0 milestone Jul 23, 2019
@jreback jreback merged commit c2293be into pandas-dev:master Jul 23, 2019
@jreback
Copy link
Contributor

jreback commented Jul 23, 2019

thanks @yanglinlee

quintusdias pushed a commit to quintusdias/pandas_dev that referenced this pull request Aug 16, 2019
@another-green @quintusdias
TST: Add test for operations on DataFrame with Interval CategoricalIn…
ff2a488 
…dex (pandas-dev#27443)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jschendel jschendel jschendel left review comments

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Categorical Categorical Data Type DataFrame DataFrame data structure Interval Interval data type Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

Using a CategoricalIndex with interval categories as column index breaks operations on a DataFrame