CLN: remove StringMixin from code base, except in core.computation #26523
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff
Removes use of
StringMixin
from pandas.io StringMixin is now only used in pandas.core.computation.I haven't been able to remove this class from core.computation. If I do, I get an error about setting an attribute:
I've looked into this and can't understand why this happens. From the looks of it, I should be able to set that atribute here, but it jusr doesn't work. I'd appreciate any hint.
I'll keep loking into removing it completely, but don't know if I'll crack that part.