Skip to content

CLN: remove StringMixin from code base, except in core.computation #26523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2019

Conversation

topper-123
Copy link
Contributor

Removes use of StringMixin from pandas.io StringMixin is now only used in pandas.core.computation.

I haven't been able to remove this class from core.computation. If I do, I get an error about setting an attribute:

        # assumes that resolvers are going from outermost scope to inner
        if isinstance(local_dict, Scope):
            resolvers += tuple(local_dict.resolvers.maps)
        self.resolvers = DeepChainMap(*resolvers)
E       AttributeError: 'Scope' object has no attribute 'resolvers'

pandas\core\computation\scope.py:134: AttributeError

I've looked into this and can't understand why this happens. From the looks of it, I should be able to set that atribute here, but it jusr doesn't work. I'd appreciate any hint.

I'll keep loking into removing it completely, but don't know if I'll crack that part.

@codecov
Copy link

codecov bot commented May 25, 2019

Codecov Report

Merging #26523 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26523      +/-   ##
==========================================
- Coverage   91.75%   91.75%   -0.01%     
==========================================
  Files         174      174              
  Lines       50665    50641      -24     
==========================================
- Hits        46489    46465      -24     
  Misses       4176     4176
Flag Coverage Δ
#multiple 90.29% <100%> (+0.03%) ⬆️
#single 41.69% <100%> (-0.11%) ⬇️
Impacted Files Coverage Δ
pandas/io/pytables.py 90.29% <100%> (+0.07%) ⬆️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba48fc4...0ee15d2. Read the comment docs.

@codecov
Copy link

codecov bot commented May 25, 2019

Codecov Report

Merging #26523 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26523      +/-   ##
==========================================
- Coverage   91.76%   91.76%   -0.01%     
==========================================
  Files         174      174              
  Lines       50653    50629      -24     
==========================================
- Hits        46482    46458      -24     
  Misses       4171     4171
Flag Coverage Δ
#multiple 90.3% <100%> (+0.03%) ⬆️
#single 41.68% <100%> (-0.11%) ⬇️
Impacted Files Coverage Δ
pandas/io/pytables.py 90.29% <100%> (+0.07%) ⬆️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2beaf3...aab3dea. Read the comment docs.

@gfyoung gfyoung added Clean Internals Related to non-user accessible pandas implementation labels May 25, 2019
@topper-123 topper-123 force-pushed the StringMix_removal branch from 0ee15d2 to 0666944 Compare May 26, 2019 06:01
@topper-123 topper-123 force-pushed the StringMix_removal branch from 0666944 to aab3dea Compare May 26, 2019 10:04
@jreback jreback added this to the 0.25.0 milestone May 26, 2019
@jreback jreback merged commit 7e88819 into pandas-dev:master May 26, 2019
@jreback
Copy link
Contributor

jreback commented May 26, 2019

thanks @topper-123

not real sure about that error you are getting above

@topper-123 topper-123 deleted the StringMix_removal branch May 26, 2019 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Internals Related to non-user accessible pandas implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants