-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Excel Test Cleanup - ReadWriteClass #26473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #26473 +/- ##
===========================================
- Coverage 91.75% 41.7% -50.06%
===========================================
Files 174 174
Lines 50765 50765
===========================================
- Hits 46578 21170 -25408
- Misses 4187 29595 +25408
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #26473 +/- ##
==========================================
- Coverage 91.75% 91.74% -0.01%
==========================================
Files 174 174
Lines 50765 50765
==========================================
- Hits 46578 46574 -4
- Misses 4187 4191 +4
Continue to review full report at Codecov.
|
@@ -60,6 +59,20 @@ def setup_method(self, datapath): | |||
self.tsframe = _tsframe.copy() | |||
self.mixed_frame = _mixed_frame.copy() | |||
|
|||
|
|||
@td.skip_if_no('xlrd', '1.0.0') | |||
class ReadingTestsBase(SharedItems): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might not be entirely apparent from the diff but to clarify here I've moved get_csv_refdf
, get_excelfile
and get_exceldf
out of the SharedItems class because they were only used by the ReaderBaseClass.
What's left in SharedItems should be replaced by fixtures where needed in the next PR
thanks @WillAyd cleanups for testing here very welcome! |
The tests we have in this module need a pretty big refactor as they mix a few testing idioms together. This is slowing down contributions on items like #25092 and #25427
This is going to require quite a few PRs to get it where it needs to be. This one simply:
I'd eventually like to get rid of the SharedItems class and use parametrization on Reader/Writer classes to test the various combinations of engines and extensions, though again going to take a few PRs to get there