CLN: Remove StringMixin from PandasObject #26505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topper-123
force-pushed
the
PandasObject_not_inherit_StringMixin
branch
from
2c94d69 to
a17e570
Compare
Codecov Report
@@ Coverage Diff @@
## master #26505 +/- ##
==========================================
+ Coverage 91.75% 91.75% +<.01%
==========================================
Files 174 174
Lines 50761 50676 -85
==========================================
- Hits 46575 46499 -76
+ Misses 4186 4177 -9
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #26505 +/- ##
==========================================
+ Coverage 91.75% 91.75% +<.01%
==========================================
Files 174 174
Lines 50761 50676 -85
==========================================
- Hits 46575 46499 -76
+ Misses 4186 4177 -9
Continue to review full report at Codecov.
|
jorisvandenbossche
approved these changes
May 24, 2019
jreback
added
Clean
Internals
|
thanks @topper-123 |
another-green
pushed a commit
to another-green/pandas
that referenced
this pull request
May 29, 2019
has2k1
added a commit
to has2k1/plydata
that referenced
this pull request
Aug 21, 2019
Response to pandas v0.25.0 so that tests can pass. pandas-dev/pandas#26505
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diffAddresses #26495. In addition to the use of StringMixin in PandasObject, StringMixin is also used in core.computation and the io.pytables. I'd like to tackle those in a different PR, as there is some funkyness there (calls that depend on frame depth etc.)