TYPING: pandas/core/window.py #27391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Typing
WillAyd
requested changes
Jul 15, 2019
pandas/core/window.py
Outdated
| min_periods: Optional[int] = None, | ||
| center: Optional[bool] = False, | ||
| win_type: Optional[str] = None, | ||
| axis: Union[str, int] = 0, |
There was a problem hiding this comment.
Can you put this in pandas._typing as Axis and reference here?
cc @topper-123 as this might conflict with your other PR
pandas/core/window.py
Outdated
| def _wrap_result(self, result, block=None, obj=None): | ||
| def _wrap_result( | ||
| self, result, block=None, obj=None | ||
| ) -> Union[ABCSeries, ABCDataFrame]: |
There was a problem hiding this comment.
Should use FrameOrSeries from pandas._typing
| @@ -63,19 +63,19 @@ class _Window(PandasObject, SelectionMixin): | |||
| "axis", | |||
| "on", | |||
| "closed", | |||
| ] | |||
| ] # type: List[str] | |||
There was a problem hiding this comment.
Was this actually throwing an error? Not opposed to it just surprised Mypy wouldn't infer this already
There was a problem hiding this comment.
Don't think so; just thought to go ahead and type.
added 3 commits
July 15, 2019 19:38
WillAyd
approved these changes
Jul 17, 2019
|
Thanks for reviewing @WillAyd! |
another-green
pushed a commit
to another-green/pandas
that referenced
this pull request
Jul 20, 2019
* TYPING: pandas/core/window.py * Address comments * Remove unused import * Sort imports
kernc
reviewed
Aug 2, 2019
| values = values.copy() | ||
| values[np.isinf(values)] = np.NaN | ||
| # Always convert inf to nan | ||
| values[np.isinf(values)] = np.NaN |
There was a problem hiding this comment.
You missed a copy call here. Results in kernc/backtesting.py#14 on write-protected arrays.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffIncludes simplifying some code paths