Skip to content

Remove py.path special handling from io.common #26458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nandahkrishna
Copy link
Contributor

@nandahkrishna nandahkrishna commented May 19, 2019

@nandahkrishna
Copy link
Contributor Author

nandahkrishna commented May 19, 2019

Just an initial commit, with the DeprecationWarning added in io/common.py on py.path.local import. Please do tell me if this is right, and what I must change/how I should proceed. Thanks.

@gfyoung gfyoung requested a review from WillAyd May 19, 2019 05:36
@gfyoung gfyoung added the Deprecate Functionality to remove in pandas label May 19, 2019
@codecov
Copy link

codecov bot commented May 19, 2019

Codecov Report

Merging #26458 into master will decrease coverage by <.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26458      +/-   ##
==========================================
- Coverage   91.73%   91.72%   -0.01%     
==========================================
  Files         174      174              
  Lines       50754    50756       +2     
==========================================
- Hits        46560    46557       -3     
- Misses       4194     4199       +5
Flag Coverage Δ
#multiple 90.23% <66.66%> (-0.01%) ⬇️
#single 41.69% <66.66%> (-0.09%) ⬇️
Impacted Files Coverage Δ
pandas/io/common.py 91.41% <66.66%> (-0.43%) ⬇️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97.02% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80bddaf...f462cc2. Read the comment docs.

@codecov
Copy link

codecov bot commented May 19, 2019

Codecov Report

Merging #26458 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26458      +/-   ##
==========================================
+ Coverage   91.73%   91.75%   +0.02%     
==========================================
  Files         174      174              
  Lines       50754    50654     -100     
==========================================
- Hits        46560    46480      -80     
+ Misses       4194     4174      -20
Flag Coverage Δ
#multiple 90.26% <100%> (+0.03%) ⬆️
#single 41.73% <100%> (-0.05%) ⬇️
Impacted Files Coverage Δ
pandas/io/common.py 94.05% <100%> (+2.21%) ⬆️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/dtypes/common.py 95.85% <0%> (-1.6%) ⬇️
pandas/core/indexes/timedeltas.py 90.96% <0%> (-0.63%) ⬇️
pandas/core/indexes/datetimes.py 96.36% <0%> (-0.49%) ⬇️
pandas/core/indexes/frozen.py 91.78% <0%> (-0.33%) ⬇️
pandas/io/excel/_base.py 91.85% <0%> (-0.29%) ⬇️
pandas/core/frame.py 97% <0%> (-0.14%) ⬇️
pandas/core/sparse/series.py 93.18% <0%> (-0.13%) ⬇️
pandas/plotting/_core.py 83.77% <0%> (-0.13%) ⬇️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80bddaf...45f0578. Read the comment docs.

@WillAyd WillAyd added this to the 0.25.0 milestone May 19, 2019
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@WillAyd WillAyd added Clean and removed Deprecate Functionality to remove in pandas labels May 20, 2019
@WillAyd WillAyd changed the title Deprecate py.path support Remove py.path special handling from io.common May 20, 2019
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls move the import; otherwise lgtm. ping on green.

@nandahkrishna
Copy link
Contributor Author

The import has been moved, and all checks pass. Is any other change required?

@WillAyd WillAyd merged commit d2beaf3 into pandas-dev:master May 26, 2019
@WillAyd
Copy link
Member

WillAyd commented May 26, 2019

Thanks!

@nandahkrishna nandahkrishna deleted the issue-26450-deprecate-py.path branch May 26, 2019 05:34
another-green pushed a commit to another-green/pandas that referenced this pull request May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate py.path support
4 participants