-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Remove py.path special handling from io.common #26458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove py.path special handling from io.common #26458
Conversation
Just an initial commit, with the DeprecationWarning added in io/common.py on py.path.local import. Please do tell me if this is right, and what I must change/how I should proceed. Thanks. |
Codecov Report
@@ Coverage Diff @@
## master #26458 +/- ##
==========================================
- Coverage 91.73% 91.72% -0.01%
==========================================
Files 174 174
Lines 50754 50756 +2
==========================================
- Hits 46560 46557 -3
- Misses 4194 4199 +5
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #26458 +/- ##
==========================================
+ Coverage 91.73% 91.75% +0.02%
==========================================
Files 174 174
Lines 50754 50654 -100
==========================================
- Hits 46560 46480 -80
+ Misses 4194 4174 -20
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls move the import; otherwise lgtm. ping on green.
The import has been moved, and all checks pass. Is any other change required? |
Thanks! |
git diff upstream/master -u -- "*.py" | flake8 --diff