Skip to content

Firestore overlays #6283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 19, 2022
Merged

Firestore overlays #6283

merged 5 commits into from
May 19, 2022

Conversation

ehsannas
Copy link
Contributor

No description provided.

ehsannas and others added 4 commits April 6, 2022 10:01
@ehsannas @dconeybe
Integrate Document Overlay with the SDK (#6123)
104964e 
* Integrate Document Overlay with the SDK.

* we should call ObjectValue.delete if value is null.

* Remove unnecessary null check from MemoryDocumentOverlayCache.saveOverlay(), like is done in firebase/firebase-android-sdk#3518

* Address comments.

* Port changes from Android SDK PR#3420.

Note that we are not going to do any processing in the background.

* Port overlay recalculation bug (Android SDK PR #3495).

* Fix overlay bug when offline (Port Android SDK PR #3537).

* Address feedback.

* Better null check.

Co-authored-by: Denver Coneybeare <[email protected]>
@ehsannas
Overlay migration (#6131)
bdd3eae 
* Overlay migration

* Remove intermediate state.

* Add test.

* Address feedback.
@ehsannas
Update overlay migration code to use DbMutationBatchStore (#6268)
736385e 
* wip.

* remove console.log.

* remove .only for test.

* lint fixes.
@ehsannas
Backport overlay bug fixes (Android PR 3691 3623) (#6274)
54011ec 
* Porting Android PR #3623.

* Port Android PR #3691.

* address feedback and add missing tests.
@changeset-bot
Copy link

changeset-bot bot commented May 18, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: d03f9b0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (1a06d5d)Merge (a1b7467)Diff
    browser253 kB257 kB+4.22 kB (+1.7%)
    esm5314 kB319 kB+4.96 kB (+1.6%)
    main506 kB515 kB+9.62 kB (+1.9%)
    module253 kB257 kB+4.22 kB (+1.7%)
    react-native253 kB257 kB+4.22 kB (+1.7%)

  • @firebase/firestore-lite

    TypeBase (1a06d5d)Merge (a1b7467)Diff
    browser73.4 kB80.5 kB+7.04 kB (+9.6%)
    esm586.9 kB96.2 kB+9.35 kB (+10.8%)
    main126 kB135 kB+9.03 kB (+7.2%)
    module73.4 kB80.5 kB+7.04 kB (+9.6%)
    react-native73.6 kB80.7 kB+7.04 kB (+9.6%)

  • bundle

    12 size changes

    TypeBase (1a06d5d)Merge (a1b7467)Diff
    firestore (Persistence)265 kB269 kB+3.91 kB (+1.5%)
    firestore (Query Cursors)204 kB208 kB+3.56 kB (+1.7%)
    firestore (Query)205 kB209 kB+3.56 kB (+1.7%)
    firestore (Read data once)194 kB197 kB+3.56 kB (+1.8%)
    firestore (Realtime updates)196 kB200 kB+3.56 kB (+1.8%)
    firestore (Transaction)178 kB181 kB+2.82 kB (+1.6%)
    firestore (Write data)177 kB181 kB+3.43 kB (+1.9%)
    firestore-lite (Query Cursors)67.8 kB67.8 kB+22 B (+0.0%)
    firestore-lite (Query)71.0 kB71.0 kB+22 B (+0.0%)
    firestore-lite (Read data once)55.4 kB55.4 kB+22 B (+0.0%)
    firestore-lite (Transaction)72.9 kB80.0 kB+7.05 kB (+9.7%)
    firestore-lite (Write data)58.1 kB65.2 kB+7.03 kB (+12.1%)

  • firebase

    TypeBase (1a06d5d)Merge (a1b7467)Diff
    firebase-compat.js783 kB787 kB+4.12 kB (+0.5%)
    firebase-firestore-compat.js305 kB309 kB+4.12 kB (+1.4%)
    firebase-firestore-lite.js251 kB267 kB+15.9 kB (+6.3%)
    firebase-firestore.js825 kB837 kB+11.4 kB (+1.4%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/MfL5kygG3c.html

@google-oss-bot
Copy link
Contributor

Size Analysis Report 1

This report is too large (587,792 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/mqf3r4AR4X.html

@ehsannas ehsannas requested a review from wu-hui May 18, 2022 20:11
@ehsannas
Copy link
Contributor Author

@wu-hui This is to merge 4 PRs that were each reviewed in the firestore-overlays branch into master.

I just had to add 1 commit that should be reviewed which resolves merge conflicts into master (see above).

Thanks

wu-hui
wu-hui approved these changes May 19, 2022
View reviewed changes
packages/firestore/test/unit/local/query_engine.test.ts
return;
}

it('combines indexed with non-indexed results', async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we port this to Android? I could not find it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why GitHub shows this as a new addition in the diff.

These tests exist in the tip-of-tree in the Web SDK. They also exist on Android. Sebastian ported these from Android to the Web via #6153

@wu-hui wu-hui assigned ehsannas and unassigned wu-hui May 19, 2022
@ehsannas ehsannas merged commit 259389a into master May 19, 2022
@ehsannas ehsannas deleted the firestore-overlays branch May 19, 2022 17:17
@firebase firebase locked and limited conversation to collaborators Jun 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wu-hui wu-hui wu-hui approved these changes

Assignees

@ehsannas ehsannas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ehsannas @google-oss-bot @wu-hui