Skip to content

Backport overlay bug fixes (Android PR 3691 3623) #6274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 18, 2022
Merged

Backport overlay bug fixes (Android PR 3691 3623) #6274

merged 3 commits into from
May 18, 2022

Conversation

ehsannas
Copy link
Contributor

@changeset-bot
Copy link

changeset-bot bot commented May 13, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1723723

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ehsannas ehsannas requested a review from wu-hui May 13, 2022 17:01
@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 13, 2022 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (736385e)Merge (5c0f138)Diff
    browser255 kB256 kB+680 B (+0.3%)
    esm5317 kB318 kB+831 B (+0.3%)
    main511 kB513 kB+1.28 kB (+0.3%)
    module255 kB256 kB+680 B (+0.3%)
    react-native255 kB256 kB+680 B (+0.3%)

  • @firebase/firestore-lite

    TypeBase (736385e)Merge (5c0f138)Diff
    browser80.1 kB80.2 kB+118 B (+0.1%)
    esm595.7 kB95.9 kB+206 B (+0.2%)
    main135 kB135 kB+118 B (+0.1%)
    module80.1 kB80.2 kB+118 B (+0.1%)
    react-native80.3 kB80.4 kB+118 B (+0.1%)

  • bundle

    TypeBase (736385e)Merge (5c0f138)Diff
    firestore (Persistence)265 kB266 kB+590 B (+0.2%)
    firestore (Query Cursors)205 kB206 kB+563 B (+0.3%)
    firestore (Query)206 kB207 kB+563 B (+0.3%)
    firestore (Read data once)195 kB195 kB+563 B (+0.3%)
    firestore (Realtime updates)197 kB198 kB+563 B (+0.3%)
    firestore (Transaction)178 kB179 kB+590 B (+0.3%)
    firestore (Write data)178 kB179 kB+680 B (+0.4%)
    firestore-lite (Transaction)78.1 kB78.2 kB+118 B (+0.2%)
    firestore-lite (Write data)63.5 kB63.6 kB+118 B (+0.2%)

  • firebase

    TypeBase (736385e)Merge (5c0f138)Diff
    firebase-compat.js782 kB783 kB+668 B (+0.1%)
    firebase-firestore-compat.js307 kB307 kB+668 B (+0.2%)
    firebase-firestore-lite.js266 kB266 kB+202 B (+0.1%)
    firebase-firestore.js829 kB832 kB+2.61 kB (+0.3%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/YSlp7r9L7P.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 13, 2022 •
edited
Loading

Size Analysis Report 1

This report is too large (438,521 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Xn4mHfGO1k.html

wu-hui
wu-hui reviewed May 17, 2022
View reviewed changes
Copy link
Contributor

@wu-hui wu-hui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two tests missing, otherwise looks good.

@wu-hui wu-hui assigned ehsannas and unassigned wu-hui May 17, 2022
@ehsannas ehsannas assigned wu-hui and unassigned ehsannas May 17, 2022
@wu-hui wu-hui assigned ehsannas and unassigned wu-hui May 18, 2022
@ehsannas ehsannas merged commit 54011ec into firestore-overlays May 18, 2022
@ehsannas ehsannas deleted the ehsann/backport-3691-3623 branch May 18, 2022 16:44
ehsannas added a commit that referenced this pull request May 19, 2022
@ehsannas @dconeybe
Firestore overlays (#6283)
259389a 
* Integrate Document Overlay with the SDK (#6123)

* Integrate Document Overlay with the SDK.

* we should call ObjectValue.delete if value is null.

* Remove unnecessary null check from MemoryDocumentOverlayCache.saveOverlay(), like is done in firebase/firebase-android-sdk#3518

* Address comments.

* Port changes from Android SDK PR#3420.

Note that we are not going to do any processing in the background.

* Port overlay recalculation bug (Android SDK PR #3495).

* Fix overlay bug when offline (Port Android SDK PR #3537).

* Address feedback.

* Better null check.

Co-authored-by: Denver Coneybeare <[email protected]>

* Overlay migration (#6131)

* Overlay migration

* Remove intermediate state.

* Add test.

* Address feedback.

* Update overlay migration code to use DbMutationBatchStore (#6268)

* wip.

* remove console.log.

* remove .only for test.

* lint fixes.

* Backport overlay bug fixes (Android PR 3691 3623) (#6274)

* Porting Android PR #3623.

* Port Android PR #3691.

* address feedback and add missing tests.

Co-authored-by: Denver Coneybeare <[email protected]>
@firebase firebase locked and limited conversation to collaborators Jun 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wu-hui wu-hui wu-hui approved these changes

Assignees

@ehsannas ehsannas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ehsannas @google-oss-bot @wu-hui