Skip to content

Integrate Document Overlay with the SDK #6123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 6, 2022

Conversation

ehsannas
Copy link
Contributor

@ehsannas ehsannas commented Apr 6, 2022

This is the same as #6054, but the pull request is made against the firestore-overlays branch.

For details of the code review, please visit #6054.

@changeset-bot
Copy link

changeset-bot bot commented Apr 6, 2022

⚠️ No Changeset found

Latest commit: d88f9f1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (d756f4e)Merge (d34c3c5)Diff
    browser252 kB255 kB+3.01 kB (+1.2%)
    esm5313 kB316 kB+3.51 kB (+1.1%)
    main503 kB510 kB+6.77 kB (+1.3%)
    module252 kB255 kB+3.01 kB (+1.2%)
    react-native252 kB255 kB+3.01 kB (+1.2%)
  • @firebase/firestore-lite

    TypeBase (d756f4e)Merge (d34c3c5)Diff
    browser73.2 kB80.1 kB+6.93 kB (+9.5%)
    esm586.6 kB95.7 kB+9.14 kB (+10.6%)
    main126 kB135 kB+8.91 kB (+7.1%)
    module73.2 kB80.1 kB+6.93 kB (+9.5%)
    react-native73.4 kB80.3 kB+6.93 kB (+9.4%)
  • bundle

    12 size changes

    TypeBase (d756f4e)Merge (d34c3c5)Diff
    firestore (Persistence)262 kB265 kB+2.79 kB (+1.1%)
    firestore (Query Cursors)202 kB205 kB+2.99 kB (+1.5%)
    firestore (Query)203 kB206 kB+2.99 kB (+1.5%)
    firestore (Read data once)192 kB195 kB+2.99 kB (+1.6%)
    firestore (Realtime updates)194 kB197 kB+2.99 kB (+1.5%)
    firestore (Transaction)176 kB178 kB+2.23 kB (+1.3%)
    firestore (Write data)176 kB178 kB+2.75 kB (+1.6%)
    firestore-lite (Query Cursors)66.3 kB66.3 kB+22 B (+0.0%)
    firestore-lite (Query)69.4 kB69.4 kB+22 B (+0.0%)
    firestore-lite (Read data once)53.8 kB53.9 kB+22 B (+0.0%)
    firestore-lite (Transaction)71.2 kB78.1 kB+6.93 kB (+9.7%)
    firestore-lite (Write data)56.6 kB63.5 kB+6.91 kB (+12.2%)

  • firebase

    TypeBase (d756f4e)Merge (d34c3c5)Diff
    firebase-compat.js778 kB781 kB+2.90 kB (+0.4%)
    firebase-firestore-compat.js303 kB306 kB+2.90 kB (+1.0%)
    firebase-firestore-lite.js250 kB266 kB+15.7 kB (+6.3%)
    firebase-firestore.js820 kB828 kB+8.13 kB (+1.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/yd5h8DrGEu.html

@google-oss-bot
Copy link
Contributor

Size Analysis Report 1

This report is too large (588,090 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/oT3I1k3YxQ.html

@schmidt-sebastian
Copy link
Contributor

FWIW You could have just change the base branch of the PR in GitHub.

@ehsannas ehsannas merged commit 104964e into firestore-overlays Apr 6, 2022
@ehsannas ehsannas deleted the ehsann/port-overlays-3 branch April 6, 2022 15:01
@firebase firebase locked and limited conversation to collaborators May 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants