Skip to content

Integrate Document Overlay with the SDK. #6054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 11 commits into from
Closed

Integrate Document Overlay with the SDK. #6054

wants to merge 11 commits into from

Conversation

ehsannas
Copy link
Contributor

@ehsannas ehsannas commented Mar 7, 2022

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Mar 7, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: d88f9f1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ehsannas ehsannas marked this pull request as draft March 7, 2022 20:30
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 7, 2022 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/app

    TypeBase (b59a56d)Merge (b4cc6db)Diff
    browser13.8 kB13.8 kB+1 B (+0.0%)
    esm518.0 kB18.0 kB+1 B (+0.0%)
    main18.9 kB18.9 kB+1 B (+0.0%)
    module13.8 kB13.8 kB+1 B (+0.0%)

  • @firebase/firestore

    TypeBase (b59a56d)Merge (b4cc6db)Diff
    browser251 kB255 kB+3.58 kB (+1.4%)
    esm5312 kB316 kB+4.08 kB (+1.3%)
    main502 kB510 kB+8.03 kB (+1.6%)
    module251 kB255 kB+3.58 kB (+1.4%)
    react-native251 kB255 kB+3.58 kB (+1.4%)

  • @firebase/firestore-lite

    TypeBase (b59a56d)Merge (b4cc6db)Diff
    browser73.2 kB80.1 kB+6.93 kB (+9.5%)
    esm586.6 kB95.7 kB+9.15 kB (+10.6%)
    main126 kB135 kB+8.91 kB (+7.1%)
    module73.2 kB80.1 kB+6.93 kB (+9.5%)
    react-native73.4 kB80.3 kB+6.93 kB (+9.4%)

  • @firebase/functions

    TypeBase (b59a56d)Merge (b4cc6db)Diff
    browser8.99 kB8.99 kB+1 B (+0.0%)
    esm511.1 kB11.1 kB+1 B (+0.0%)
    main11.8 kB11.8 kB+1 B (+0.0%)
    module8.99 kB8.99 kB+1 B (+0.0%)

  • bundle

    43 size changes

    TypeBase (b59a56d)Merge (b4cc6db)Diff
    analytics (logEvent)40.0 kB40.0 kB+1 B (+0.0%)
    app-check (CustomProvider)33.7 kB33.7 kB+1 B (+0.0%)
    app-check (ReCaptchaEnterpriseProvider)35.9 kB35.9 kB+1 B (+0.0%)
    app-check (ReCaptchaV3Provider)35.8 kB35.8 kB+1 B (+0.0%)
    auth (Anonymous)63.5 kB63.5 kB+2 B (+0.0%)
    auth (EmailAndPassword)67.6 kB67.6 kB+2 B (+0.0%)
    auth (GoogleFBTwitterGitHubPopup)87.3 kB87.3 kB+2 B (+0.0%)
    auth (GooglePopup)87.1 kB87.1 kB+2 B (+0.0%)
    auth (GoogleRedirect)87.3 kB87.3 kB+2 B (+0.0%)
    auth (Phone)73.6 kB73.6 kB+2 B (+0.0%)
    database (Append to a list of data)143 kB143 kB+2 B (+0.0%)
    database (Filtering data)142 kB142 kB+2 B (+0.0%)
    database (Listen for child events)158 kB158 kB+2 B (+0.0%)
    database (Listen for value events + Detach listeners)158 kB158 kB+2 B (+0.0%)
    database (Listen for value events)158 kB158 kB+2 B (+0.0%)
    database (Read data once)150 kB150 kB+2 B (+0.0%)
    database (Save data as transactions)160 kB160 kB+2 B (+0.0%)
    database (Sort data)144 kB144 kB+2 B (+0.0%)
    database (Write data)143 kB143 kB+2 B (+0.0%)
    firestore (Persistence)261 kB265 kB+3.37 kB (+1.3%)
    firestore (Query Cursors)202 kB205 kB+3.00 kB (+1.5%)
    firestore (Query)203 kB206 kB+3.00 kB (+1.5%)
    firestore (Read data once)192 kB195 kB+3.00 kB (+1.6%)
    firestore (Realtime updates)194 kB197 kB+3.00 kB (+1.5%)
    firestore (Transaction)176 kB178 kB+2.23 kB (+1.3%)
    firestore (Write data)176 kB178 kB+2.76 kB (+1.6%)
    firestore-lite (Query Cursors)66.3 kB66.3 kB+25 B (+0.0%)
    firestore-lite (Query)69.4 kB69.4 kB+25 B (+0.0%)
    firestore-lite (Read data once)53.8 kB53.9 kB+25 B (+0.0%)
    firestore-lite (Transaction)71.2 kB78.1 kB+6.94 kB (+9.7%)
    firestore-lite (Write data)56.6 kB63.5 kB+6.91 kB (+12.2%)
    functions (call)27.6 kB27.6 kB+2 B (+0.0%)
    messaging (send + receive)43.3 kB43.3 kB+1 B (+0.0%)
    performance (trace)47.7 kB47.7 kB+1 B (+0.0%)
    remote-config (getAndFetch)42.3 kB42.3 kB+2 B (+0.0%)
    storage (getBytes)35.9 kB35.9 kB+2 B (+0.0%)
    storage (getDownloadURL)38.0 kB38.0 kB+2 B (+0.0%)
    storage (getMetadata)37.4 kB37.4 kB+2 B (+0.0%)
    storage (list + listAll)36.9 kB36.9 kB+2 B (+0.0%)
    storage (updateMetadata)37.7 kB37.7 kB+2 B (+0.0%)
    storage (uploadBytes)42.2 kB42.2 kB+2 B (+0.0%)
    storage (uploadBytesResumable)51.7 kB51.7 kB+2 B (+0.0%)
    storage (uploadString)42.5 kB42.5 kB+2 B (+0.0%)

  • firebase

    21 size changes

    TypeBase (b59a56d)Merge (b4cc6db)Diff
    firebase-analytics.js105 kB105 kB+3 B (+0.0%)
    firebase-app-check.js90.0 kB90.1 kB+4 B (+0.0%)
    firebase-app-compat.js26.4 kB26.4 kB+2 B (+0.0%)
    firebase-app.js81.5 kB81.5 kB+8 B (+0.0%)
    firebase-auth-cordova.js463 kB463 kB+1 B (+0.0%)
    firebase-auth-react-native.js492 kB492 kB+1 B (+0.0%)
    firebase-auth.js412 kB412 kB+2 B (+0.0%)
    firebase-compat.js778 kB781 kB+3.38 kB (+0.4%)
    firebase-database.js603 kB603 kB+4 B (+0.0%)
    firebase-firestore-compat.js303 kB306 kB+3.38 kB (+1.1%)
    firebase-firestore-lite.js250 kB266 kB+15.7 kB (+6.3%)
    firebase-firestore.js821 kB828 kB+6.83 kB (+0.8%)
    firebase-functions-compat.js7.95 kB7.95 kB+1 B (+0.0%)
    firebase-functions.js31.1 kB31.1 kB+3 B (+0.0%)
    firebase-messaging-sw.js101 kB101 kB+1 B (+0.0%)
    firebase-messaging.js99.4 kB99.4 kB+1 B (+0.0%)
    firebase-performance-standalone-compat.es2017.js86.5 kB86.5 kB+3 B (+0.0%)
    firebase-performance-standalone-compat.js64.0 kB64.0 kB+3 B (+0.0%)
    firebase-performance.js117 kB117 kB+3 B (+0.0%)
    firebase-remote-config.js106 kB106 kB+2 B (+0.0%)
    firebase-storage.js146 kB146 kB+1 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/wAf61cPdFD.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 7, 2022 •
edited
Loading

Size Analysis Report 1

This report is too large (794,206 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/sc8wc1gs3g.html

@ehsannas ehsannas force-pushed the ehsann/port-overlays-3 branch from cea4510 to 6d69bb8 Compare March 7, 2022 22:36
@ehsannas ehsannas mentioned this pull request Mar 8, 2022
Closed
@ehsannas ehsannas force-pushed the ehsann/port-overlays-3 branch from 6d69bb8 to 5f88728 Compare March 8, 2022 17:50
@ehsannas ehsannas marked this pull request as ready for review March 8, 2022 19:19
schmidt-sebastian
schmidt-sebastian reviewed Mar 9, 2022
View reviewed changes
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. Must have been fun to spot all the code you had to port :/

Note that we cannot merge this into master until we have the code that migrates the existing mutations to overlays.

@ehsannas ehsannas force-pushed the ehsann/port-overlays-3 branch from fdb9209 to ec8fe08 Compare March 10, 2022 22:28
schmidt-sebastian
schmidt-sebastian reviewed Mar 28, 2022
View reviewed changes
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updated. Please hold off on merging until we have come up with a migration strategy.

@ehsannas
Copy link
Contributor Author

ehsannas commented Apr 4, 2022

I'll create a new PR against a new overlay branch once this PR is approved.

schmidt-sebastian
schmidt-sebastian reviewed Apr 4, 2022
View reviewed changes
schmidt-sebastian
schmidt-sebastian reviewed Apr 4, 2022
View reviewed changes
@ehsannas ehsannas mentioned this pull request Apr 6, 2022
Merged
@ehsannas
Copy link
Contributor Author

ehsannas commented Apr 6, 2022

I'll close this as we don't want to merge it into master yet. I'd rather land the squashed changes in to a new branch (firestore-overlays) done via #6123

@ehsannas ehsannas closed this Apr 6, 2022
@ehsannas ehsannas deleted the ehsann/port-overlays-3 branch April 6, 2022 15:01
@firebase firebase locked and limited conversation to collaborators May 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

Assignees

@ehsannas ehsannas

Labels
do-not-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ehsannas @google-oss-bot @schmidt-sebastian @dconeybe