we should call ObjectValue.delete if value is null.

ehsannas · ehsannas · commit 6d69bb8d1d8d · 2022-03-07T16:36:36.000-06:00
diff --git a/packages/firestore/src/model/mutation.ts b/packages/firestore/src/model/mutation.ts
@@ -255,7 +255,11 @@ export function calculateOverlayMutation(
         if (value === null && path.length > 1) {
           path = path.popLast();
         }
-        patchValue.set(path, docValue.field(path)!);
+        if (value === null) {
+          patchValue.delete(path);
+        } else {
+          patchValue.set(path, value);
+        }
         maskSet = maskSet.add(path);
       }
     });

Original file line number	Diff line number	Diff line change
`@@ -255,7 +255,11 @@ export function calculateOverlayMutation(`
`255`	`255`	`if (value === null && path.length > 1) {`
`256`	`256`	`path = path.popLast();`
`257`	`257`	`}`
`258`		`- patchValue.set(path, docValue.field(path)!);`
	`258`	`+ if (value === null) {`
	`259`	`+ patchValue.delete(path);`
	`260`	`+ } else {`
	`261`	`+ patchValue.set(path, value);`
	`262`	`+ }`
`259`	`263`	`maskSet = maskSet.add(path);`
`260`	`264`	`}`
`261`	`265`	`});`