Overlay migration #6131
Merged
Overlay migration #6131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ehsannas
force-pushed
the
ehsann/overlay-migration-2
branch
from
71f0862 to
0a979d0
Compare
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1This report is too large (410,370 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
schmidt-sebastian
approved these changes
Apr 15, 2022
| batchId: 5, | ||
| localWriteTimeMs: 1337, | ||
| baseMutations: undefined, | ||
| mutations: [testWritePending] |
There was a problem hiding this comment.
Should this be user3 with no mutations?
packages/firestore/test/unit/local/indexeddb_persistence.test.ts
Outdated
Show resolved
Hide resolved
| } | ||
| ).next(() => | ||
| // Populate the mutation queues' metadata | ||
| PersistencePromise.waitFor([ |
There was a problem hiding this comment.
You can probably use the loop above to also add this data and then just simply call .put({userId: user, lastAcknowledgedBatchId: -1, lastStreamToken: ''}) at each iteration. That way you only have one source of truth for your data.
packages/firestore/test/unit/local/indexeddb_persistence.test.ts
Outdated
Show resolved
Hide resolved
packages/firestore/test/unit/local/indexeddb_persistence.test.ts
Outdated
Show resolved
Hide resolved
ehsannas
added a commit
that referenced
this pull request
May 19, 2022
* Integrate Document Overlay with the SDK (#6123) * Integrate Document Overlay with the SDK. * we should call ObjectValue.delete if value is null. * Remove unnecessary null check from MemoryDocumentOverlayCache.saveOverlay(), like is done in firebase/firebase-android-sdk#3518 * Address comments. * Port changes from Android SDK PR#3420. Note that we are not going to do any processing in the background. * Port overlay recalculation bug (Android SDK PR #3495). * Fix overlay bug when offline (Port Android SDK PR #3537). * Address feedback. * Better null check. Co-authored-by: Denver Coneybeare <[email protected]> * Overlay migration (#6131) * Overlay migration * Remove intermediate state. * Add test. * Address feedback. * Update overlay migration code to use DbMutationBatchStore (#6268) * wip. * remove console.log. * remove .only for test. * lint fixes. * Backport overlay bug fixes (Android PR 3691 3623) (#6274) * Porting Android PR #3623. * Port Android PR #3691. * address feedback and add missing tests. Co-authored-by: Denver Coneybeare <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.