Skip to content

Update overlay migration code to use DbMutationBatchStore #6268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 12, 2022
Merged

Update overlay migration code to use DbMutationBatchStore #6268

merged 4 commits into from
May 12, 2022

Conversation

ehsannas
Copy link
Contributor

Use the mutations store (DbMutationBatchStore), rather than mutation queue (DbMutationQueueStore) to get the set of documents needed for overlay migration for each user.

@changeset-bot
Copy link

changeset-bot bot commented May 11, 2022

⚠️ No Changeset found

Latest commit: 2cf4c72

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ehsannas ehsannas requested a review from wu-hui May 11, 2022 20:15
@ehsannas ehsannas changed the title Ehsann/test firestore overlay migration Update overlay migration code to use DbMutationBatchStore May 11, 2022
@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (bdd3eae)Merge (81b1597)Diff
    browser255 kB255 kB-143 B (-0.1%)
    esm5317 kB317 kB-173 B (-0.1%)
    main512 kB511 kB-219 B (-0.0%)
    module255 kB255 kB-143 B (-0.1%)
    react-native255 kB255 kB-143 B (-0.1%)

  • bundle

    TypeBase (bdd3eae)Merge (81b1597)Diff
    firestore (Persistence)265 kB265 kB-144 B (-0.1%)

  • firebase

    TypeBase (bdd3eae)Merge (81b1597)Diff
    firebase-compat.js782 kB782 kB-136 B (-0.0%)
    firebase-firestore-compat.js307 kB307 kB-136 B (-0.0%)
    firebase-firestore.js830 kB829 kB-662 B (-0.1%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/gzduB59szK.html

@google-oss-bot
Copy link
Contributor

Size Analysis Report 1

Affected Products

  • @firebase/firestore

    • enableIndexedDbPersistence

      Size

      TypeBase (bdd3eae)Merge (81b1597)Diff
      size168 kB168 kB-143 B (-0.1%)
      size-with-ext-deps227 kB227 kB-144 B (-0.1%)

    • enableMultiTabIndexedDbPersistence

      Size

      TypeBase (bdd3eae)Merge (81b1597)Diff
      size200 kB200 kB-143 B (-0.1%)
      size-with-ext-deps259 kB259 kB-144 B (-0.1%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Za8zzDupf3.html

@wu-hui wu-hui assigned ehsannas and unassigned wu-hui May 12, 2022
@ehsannas ehsannas merged commit 736385e into firestore-overlays May 12, 2022
@ehsannas ehsannas deleted the ehsann/test-firestore-overlay-migration branch May 12, 2022 15:12
ehsannas added a commit that referenced this pull request May 19, 2022
@ehsannas @dconeybe
Firestore overlays (#6283)
259389a 
* Integrate Document Overlay with the SDK (#6123)

* Integrate Document Overlay with the SDK.

* we should call ObjectValue.delete if value is null.

* Remove unnecessary null check from MemoryDocumentOverlayCache.saveOverlay(), like is done in firebase/firebase-android-sdk#3518

* Address comments.

* Port changes from Android SDK PR#3420.

Note that we are not going to do any processing in the background.

* Port overlay recalculation bug (Android SDK PR #3495).

* Fix overlay bug when offline (Port Android SDK PR #3537).

* Address feedback.

* Better null check.

Co-authored-by: Denver Coneybeare <[email protected]>

* Overlay migration (#6131)

* Overlay migration

* Remove intermediate state.

* Add test.

* Address feedback.

* Update overlay migration code to use DbMutationBatchStore (#6268)

* wip.

* remove console.log.

* remove .only for test.

* lint fixes.

* Backport overlay bug fixes (Android PR 3691 3623) (#6274)

* Porting Android PR #3623.

* Port Android PR #3691.

* address feedback and add missing tests.

Co-authored-by: Denver Coneybeare <[email protected]>
@firebase firebase locked and limited conversation to collaborators Jun 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wu-hui wu-hui wu-hui approved these changes

Assignees

@ehsannas ehsannas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ehsannas @google-oss-bot @wu-hui