Skip to content

Port QueryEngine #6153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 19, 2022
Merged

Port QueryEngine #6153

merged 7 commits into from
Apr 19, 2022

Conversation

schmidt-sebastian
Copy link
Contributor

This ports the query engine changes for indexed query execution from Android.

@changeset-bot
Copy link

changeset-bot bot commented Apr 14, 2022

⚠️ No Changeset found

Latest commit: b7999a9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

This ports the query engine changes for indexed query execution from Android
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 14, 2022

Size Report 1

Affected Products

  • @firebase/app-check

    TypeBase (95c59fe)Merge (ca134b3)Diff
    browser25.2 kB25.2 kB-10 B (-0.0%)
    esm529.8 kB29.8 kB-10 B (-0.0%)
    main31.0 kB31.0 kB-10 B (-0.0%)
    module25.2 kB25.2 kB-10 B (-0.0%)
  • @firebase/firestore

    TypeBase (95c59fe)Merge (ca134b3)Diff
    browser252 kB253 kB+532 B (+0.2%)
    esm5313 kB314 kB+808 B (+0.3%)
    main504 kB505 kB+1.04 kB (+0.2%)
    module252 kB253 kB+532 B (+0.2%)
    react-native252 kB253 kB+532 B (+0.2%)
  • @firebase/firestore-lite

    TypeBase (95c59fe)Merge (ca134b3)Diff
    browser73.2 kB73.1 kB-30 B (-0.0%)
    esm586.6 kB86.5 kB-30 B (-0.0%)
    main126 kB126 kB-92 B (-0.1%)
    module73.2 kB73.1 kB-30 B (-0.0%)
    react-native73.4 kB73.3 kB-30 B (-0.0%)
  • bundle

    12 size changes

    TypeBase (95c59fe)Merge (ca134b3)Diff
    app-check (CustomProvider)33.7 kB33.7 kB-15 B (-0.0%)
    app-check (ReCaptchaEnterpriseProvider)35.9 kB35.9 kB-15 B (-0.0%)
    app-check (ReCaptchaV3Provider)35.9 kB35.8 kB-10 B (-0.0%)
    firestore (Persistence)262 kB263 kB+520 B (+0.2%)
    firestore (Query Cursors)202 kB203 kB+297 B (+0.1%)
    firestore (Query)203 kB204 kB+297 B (+0.1%)
    firestore (Read data once)192 kB192 kB+285 B (+0.1%)
    firestore (Realtime updates)194 kB194 kB+297 B (+0.2%)
    firestore (Transaction)176 kB177 kB+256 B (+0.1%)
    firestore (Write data)176 kB176 kB+256 B (+0.1%)
    firestore-lite (Query Cursors)66.3 kB66.3 kB-30 B (-0.0%)
    firestore-lite (Query)69.4 kB69.4 kB-30 B (-0.0%)

  • firebase

    TypeBase (95c59fe)Merge (ca134b3)Diff
    firebase-app-check-compat.js22.7 kB22.7 kB-10 B (-0.0%)
    firebase-app-check.js90.1 kB90.0 kB-10 B (-0.0%)
    firebase-compat.js779 kB779 kB+536 B (+0.1%)
    firebase-firestore-compat.js304 kB304 kB+546 B (+0.2%)
    firebase-firestore-lite.js250 kB250 kB-29 B (-0.0%)
    firebase-firestore.js822 kB824 kB+2.18 kB (+0.3%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/6WULccSkzS.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 14, 2022

Size Analysis Report 1

This report is too large (468,403 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/CnNqmqZmKh.html

@wu-hui wu-hui assigned schmidt-sebastian and unassigned wu-hui Apr 15, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 15, 2022

Changeset File Check ✅

  • No modified packages are missing from the changeset file.
  • No changeset formatting errors detected.

@schmidt-sebastian schmidt-sebastian merged commit 9417675 into master Apr 19, 2022
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/queryengine branch April 19, 2022 15:45
@ehsannas ehsannas mentioned this pull request May 19, 2022
@firebase firebase locked and limited conversation to collaborators May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants