Implement Firestore IndexBackfiller #6261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Integrate Document Overlay with the SDK. * we should call ObjectValue.delete if value is null. * Remove unnecessary null check from MemoryDocumentOverlayCache.saveOverlay(), like is done in firebase/firebase-android-sdk#3518 * Address comments. * Port changes from Android SDK PR#3420. Note that we are not going to do any processing in the background. * Port overlay recalculation bug (Android SDK PR #3495). * Fix overlay bug when offline (Port Android SDK PR #3537). * Address feedback. * Better null check. Co-authored-by: Denver Coneybeare <[email protected]>
* Overlay migration * Remove intermediate state. * Add test. * Address feedback.
|
* wip. * remove console.log. * remove .only for test. * lint fixes.
…to tomandersen/index-backfiller # Conflicts: # packages/firestore/src/core/component_provider.ts # packages/firestore/src/local/index_backfiller.ts # packages/firestore/src/local/persistence_promise.ts # packages/firestore/test/unit/specs/spec_test_components.ts
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1This report is too large (848,661 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
tom-andersen
commented
May 18, 2022
tom-andersen
commented
May 18, 2022
wu-hui
reviewed
May 18, 2022
ehsannas
added a commit
that referenced
this pull request
May 26, 2022
This is porting firebase/firebase-android-sdk#3657 to the Web SDK. The majority of the code was ported as a part of other PRs such as #6153. The only thing remaining is to port the tests in SQLiteLocalStoreTest.java which will be done as a part of #6261.
ehsannas
added a commit
that referenced
this pull request
May 27, 2022
This is porting firebase/firebase-android-sdk#3657 to the Web SDK. The majority of the code was ported as a part of other PRs such as #6153. The only thing remaining is to port the tests in SQLiteLocalStoreTest.java which will be done as a part of #6261.
…into tomandersen/index-backfiller
Changeset File Check ✅
|
ehsannas
reviewed
Jun 2, 2022
ehsannas
reviewed
Jun 2, 2022
wu-hui
approved these changes
Jun 6, 2022
| }) | ||
| ); | ||
|
|
||
| // Documents before read time should not be fetched. |
| 'coll2' | ||
| ); | ||
| }); | ||
|
|
There was a problem hiding this comment.
I think you are missing:
testBackfillUsesDocumentKeyOffsetForLargeSnapshots
?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement index backfiller