Skip to content

Re-run limit queries without limit if they need to be re-filled #3657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 20, 2022
Merged

Re-run limit queries without limit if they need to be re-filled #3657

merged 8 commits into from
May 20, 2022

Conversation

schmidt-sebastian
Copy link
Contributor

This changes the query engine to also drop the limit on limit queries that need to be refilled. It also cleans up some of the Target.getLimit() logic that leads to repetitive code.

@schmidt-sebastian
Re-run limit queries without limit if they need to be re-filled
d8800bd 
This changes the query engine to also drop the limit on limit queries that need to be refilled. It also cleans up some of the Target.getLimit() logic that leads to repetitive code.
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 15, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 46.28% (7f0bff1) to 46.08% (c1106e1) by -0.20%.

    11 individual files with coverage change

    FilenameBase (7f0bff1)Merge (c1106e1)Diff
    AsyncQueue.java78.61%78.11%-0.50%
    Datastore.java32.14%29.76%-2.38%
    DeleteMutation.java95.24%90.48%-4.76%
    FirestoreChannel.java18.10%16.38%-1.72%
    FirestoreClient.java38.52%31.11%-7.41%
    GrpcCallProvider.java69.41%62.35%-7.06%
    IndexBackfiller.java92.19%76.56%-15.63%
    LruGarbageCollector.java93.46%84.11%-9.35%
    QueryEngine.java98.68%98.63%-0.05%
    SetMutation.java97.22%94.44%-2.78%
    View.java96.82%96.79%-0.02%

Test Logs

Notes

  • Commit (c1106e1) is created by Prow via merging PR base commit (7f0bff1) and head commit (916e075).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/fJrmfj0sel.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 15, 2022 •
edited
Loading

Size Report 1

Affected Products

  • firebase-firestore

    TypeBase (7f0bff1)Merge (c1106e1)Diff
    aar1.25 MB1.25 MB-112 B (-0.0%)
    apk (release)3.38 MB3.38 MB-260 B (-0.0%)

Test Logs

Notes

  • Commit (c1106e1) is created by Prow via merging PR base commit (7f0bff1) and head commit (916e075).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/jaQiZid4UC.html

@schmidt-sebastian schmidt-sebastian mentioned this pull request Apr 15, 2022
Merged
@schmidt-sebastian
Copy link
Contributor Author

I am not sure why the test is failing... I am still trying to debug it.

@schmidt-sebastian
Copy link
Contributor Author

Should be fixed now.

@schmidt-sebastian
Copy link
Contributor Author

/test device-check-changed

@ehsannas ehsannas merged commit 56c238c into master May 20, 2022
@ehsannas ehsannas deleted the mrschmidt/droplimit branch May 20, 2022 16:46
ehsannas added a commit to firebase/firebase-js-sdk that referenced this pull request May 26, 2022
@ehsannas
Rerun limit queries if a partial index is available.
fe1d5fa 
This is porting firebase/firebase-android-sdk#3657 to
the Web SDK. The majority of the code was ported as a part of other PRs such as
#6153.

The only thing remaining is to port the tests in SQLiteLocalStoreTest.java which
will be done as a part of #6261.
@ehsannas ehsannas mentioned this pull request May 26, 2022
Merged
ehsannas added a commit to firebase/firebase-js-sdk that referenced this pull request May 27, 2022
@ehsannas
Rerun limit queries if a partial index is available. (#6301)
8d03c8a 
This is porting firebase/firebase-android-sdk#3657 to
the Web SDK. The majority of the code was ported as a part of other PRs such as
#6153.

The only thing remaining is to port the tests in SQLiteLocalStoreTest.java which
will be done as a part of #6261.
@firebase firebase locked and limited conversation to collaborators Jun 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ehsannas ehsannas ehsannas approved these changes

Assignees

@ehsannas ehsannas

Labels
api: firestore size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schmidt-sebastian @google-oss-bot @ehsannas