Skip to content

Field Value migration #2784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Mar 25, 2020
Merged

Field Value migration #2784

merged 28 commits into from
Mar 25, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Mar 23, 2020

This PR merges the FieldValue migration to Protobuf into master. It only contains previously reviewed changes and no remaining TODOs.

While this is ready for merge, I will hold off until this week's release has been cut, as the this release already contains the Memory-only Firestore refactor.

@schmidt-sebastian
Copy link
Contributor Author

This week's release has been cut.

Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wilhuff wilhuff assigned schmidt-sebastian and unassigned wilhuff Mar 25, 2020
@schmidt-sebastian schmidt-sebastian merged commit cae4645 into master Mar 25, 2020
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/rewritefieldvalue branch March 26, 2020 03:05
schmidt-sebastian added a commit that referenced this pull request Mar 26, 2020
@firebase firebase locked and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants