Adding test utilities to create Value types #2680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmidt-sebastian
force-pushed
the
mrschmidt/rewritefieldvalue-3
branch
from
7e948ab to
e034fd5
Compare
schmidt-sebastian
force-pushed
the
mrschmidt/rewritefieldvalue-3
branch
from
e034fd5 to
49102ea
Compare
wu-hui
reviewed
Feb 26, 2020
| for (let i = 0; i < entries.length; i += 2) { | ||
| result.mapValue!.fields![entries[i] as string] = valueOf( | ||
| entries[i + 1], | ||
| /* useProto3Json= */ false |
There was a problem hiding this comment.
Curious: why is it OK to set it to always false here?
There was a problem hiding this comment.
For now, this is a test utility only. The best I can tell you that we will find out soon if it indeed is ok.
wu-hui
approved these changes
Feb 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port of firebase/firebase-android-sdk#1158