Use ByteString in model types #2676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmidt-sebastian
force-pushed
the
mrschmidt/apiblob
branch
from
792556b to
259f742
Compare
schmidt-sebastian
force-pushed
the
mrschmidt/apiblob
branch
from
259f742 to
a887b04
Compare
| @@ -70,26 +65,6 @@ describe('Blob', () => { | |||
| expect(Blob.fromBase64String('') instanceof PublicBlob).to.equal(true); | |||
| }); | |||
|
|
|||
| it('compares correctly', () => { | |||
There was a problem hiding this comment.
FYI: The ordering is also tested in field_value.test.ts
wilhuff
approved these changes
Feb 25, 2020
|
The canonical tests will cover this type when it is ported, so we will have a test then: https://github.com/firebase/firebase-android-sdk/pull/1178/files#diff-439fbbe706d75bbdf003c18383525777R379 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simplification that removes the api Blob types from our FieldValue API and exposed ByteString.compareTo() which I would like to use in the FieldValue rewrite.
This PR is against the feature branch since it might break canonical IDs.