Explicit byte size accounting #2689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The goal of this PR is to support fast comparisons for Timestamp types when the Timestamps are represented as ISO dates
var-const
approved these changes
Mar 3, 2020
| function estimateArrayByteSize(arrayValue: api.ArrayValue): number { | ||
| let size = 0; | ||
| for (const value of arrayValue.values || []) { | ||
| size += estimateByteSize(value); |
There was a problem hiding this comment.
Optional: this looks like reduce, though it doesn't look like it would change things substantially.
There was a problem hiding this comment.
I like it. Rewritten.
| return `geo(${geoPoint.latitude},${geoPoint.longitude})`; | ||
| } | ||
|
|
||
| function canoifyMap(mapValue: api.MapValue) : string { | ||
| function canoifyMap(mapValue: api.MapValue): string { |
There was a problem hiding this comment.
Nit: typo (s/canoify/canonify/).
schmidt-sebastian
changed the base branch from
mrschmidt/rewritefieldvalue-8
to
mrschmidt/rewritefieldvalue
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This copies the existing byte size accounting from the FieldValue classes and exposes it via Proto-only methods.