Skip to content

Simplify Document #1179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2020
Merged

Conversation

schmidt-sebastian
Copy link
Contributor

This basically reverts #561 since it will no longer be needed when all FieldValues expose the full Proto interface. It also brings back the old signature to the Document constructor.

@codecov
Copy link

codecov bot commented Jan 30, 2020

Codecov Report

❗ No coverage uploaded for pull request base (mrschmidt/rewritefieldvalue@9354294). Click here to learn what that means.
The diff coverage is 87.5%.

Flag Coverage Δ Complexity Δ
#FirebaseFirestore 62.22% <87.5%> (?) 2344 <1> (?)
#FirebaseFirestore_Ktx 41.17% <ø> (?) 0 <ø> (?)
Impacted Files Coverage Δ Complexity Δ
...firebase/firestore/model/mutation/SetMutation.java 64% <100%> (ø) 8 <0> (?)
...ogle/firebase/firestore/local/LocalSerializer.java 94.11% <100%> (ø) 25 <0> (?)
...se/firestore/model/mutation/TransformMutation.java 81.92% <100%> (ø) 22 <0> (?)
.../com/google/firebase/firestore/model/Document.java 83.78% <100%> (ø) 20 <1> (?)
...rebase/firestore/model/mutation/PatchMutation.java 82.22% <100%> (ø) 16 <0> (?)
...le/firebase/firestore/remote/RemoteSerializer.java 79.31% <50%> (ø) 147 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9354294...d458ec3. Read the comment docs.

Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wilhuff wilhuff assigned schmidt-sebastian and unassigned wilhuff Jan 30, 2020
@schmidt-sebastian schmidt-sebastian merged commit 3893dcb into mrschmidt/rewritefieldvalue Jan 30, 2020
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/simplify branch February 7, 2020 00:22
schmidt-sebastian added a commit to firebase/firebase-js-sdk that referenced this pull request Feb 27, 2020
@firebase firebase locked and limited conversation to collaborators Mar 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants