Add small Proto helpers #2753
Add small Proto helpers #2753
Conversation
schmidt-sebastian
force-pushed
the
mrschmidt/smallhelpers
branch
from
a9cc1f2 to
3ee49d5
Compare
schmidt-sebastian
force-pushed
the
mrschmidt/smallhelpers
branch
from
3ee49d5 to
69ffaf0
Compare
|
|
||
| /** Returns true if `value` is NaN. */ | ||
| export function isNanValue(value?: api.Value | null): boolean { | ||
| return !!value && isNaN(Number(value.doubleValue)); |
There was a problem hiding this comment.
This doesn't actually test that value is a double. Should this be isDouble(value) && isNaN(Number(value.doubleValue));?
There was a problem hiding this comment.
Ugh JavaScript:
isNaN(Number(null)) => false
isNaN(Number(undefined)) => true
So it looks like we need to test here that value.doubleValue is set.
| @@ -539,3 +539,43 @@ export function normalizeByteString(blob: string | Uint8Array): ByteString { | |||
| return ByteString.fromUint8Array(blob); | |||
| } | |||
| } | |||
|
|
|||
| /** Returns true if `value` is an IntegerValue. */ | |||
| export function isInteger(value?: api.Value | null): boolean { | |||
There was a problem hiding this comment.
If we defined an interface like
exporter interface IntegerValue {
integerValue: number;
}Then we could make this a type guard:
export function isInteger(value?: api.Value | null): value is IntegerValue {
return !!value && 'integerValue' in value;
}This PR doesn't include any uses of these functions, so it's not clear that this would necessarily be a win, but it seems like this could be helpful.
There was a problem hiding this comment.
I updated the PR to allow us to make asserts on the input type, but I kept it in the method declarations for now and did not plumb through separate types. This should allow us to get rid of bangs for future usages.
| export function isNanValue( | ||
| value?: api.Value | null | ||
| ): value is { doubleValue: 'NaN' | number } { | ||
| return !!value && isDouble(value) && isNaN(Number(value.doubleValue)); |
There was a problem hiding this comment.
isDouble already tests !!value so you can drop it here.
schmidt-sebastian
changed the base branch from
mrschmidt/valuesrename
to
mrschmidt/rewritefieldvalue
Small PR with some helpers that will be used in NumericIncrementTransforms and other places.