-
Notifications
You must be signed in to change notification settings - Fork 934
Add small Proto helpers #2753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
schmidt-sebastian
merged 17 commits into
mrschmidt/rewritefieldvalue
from
mrschmidt/smallhelpers
Mar 19, 2020
Merged
Add small Proto helpers #2753
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
05bb427
Move test code without touching
schmidt-sebastian d69fe94
Rename proto_values->values, create values.test.ts
schmidt-sebastian 69ffaf0
Add small Proto helpers
schmidt-sebastian c5d598b
Fix field_value.test.ts
schmidt-sebastian d55fc37
Merge branch 'mrschmidt/valuesrename' into mrschmidt/smallhelpers
schmidt-sebastian 51503ca
Clean up imports
schmidt-sebastian d2d6622
Merge branch 'mrschmidt/valuesrename' into mrschmidt/smallhelpers
schmidt-sebastian 47b1379
Merge
schmidt-sebastian 39ff5bc
Lint
schmidt-sebastian cc76c51
Merge branch 'mrschmidt/valuesrename' into mrschmidt/smallhelpers
schmidt-sebastian a4aa9b6
Review
schmidt-sebastian 6a33327
Merge
schmidt-sebastian 5f0779d
Fix build
schmidt-sebastian a4b4b53
Fix import
schmidt-sebastian c82c97f
Merge branch 'mrschmidt/valuesrename' into mrschmidt/smallhelpers
schmidt-sebastian e25cca2
Merge branch 'mrschmidt/rewritefieldvalue' into mrschmidt/smallhelpers
schmidt-sebastian 31b567a
Update values.ts
schmidt-sebastian File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isDouble
already tests!!value
so you can drop it here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done