Skip to content

Limit Timestamp normalization #2684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

schmidt-sebastian
Copy link
Contributor

The goal of this PR is to support fast comparisons for Timestamp types when the Timestamps are represented as ISO dates

@schmidt-sebastian schmidt-sebastian force-pushed the mrschmidt/rewritefieldvalue-5 branch from 403da9e to 2c46e61 Compare February 27, 2020 00:44
The goal of this PR is to support fast comparisons for Timestamp types when the Timestamps are represented as ISO dates
Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wilhuff wilhuff assigned schmidt-sebastian and unassigned wilhuff Feb 27, 2020
@schmidt-sebastian schmidt-sebastian changed the base branch from mrschmidt/rewritefieldvalue-4 to mrschmidt/rewritefieldvalue March 4, 2020 23:26
@schmidt-sebastian schmidt-sebastian merged commit 5a603db into mrschmidt/rewritefieldvalue Mar 4, 2020
@firebase firebase locked and limited conversation to collaborators Apr 4, 2020
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/rewritefieldvalue-5 branch April 6, 2020 19:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants