Skip to content

Convert the specification files to rst format #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
26 tasks done
steff456 opened this issue Oct 12, 2021 · 7 comments
Closed
26 tasks done

Convert the specification files to rst format #283

steff456 opened this issue Oct 12, 2021 · 7 comments
Assignees
Labels
Maintenance Bug fix, typo fix, or general maintenance.
Milestone

Comments

@steff456
Copy link
Member

steff456 commented Oct 12, 2021

The main goal is to make the specification files more machine readable and enable sphinx extensions like latex to convert into a pdf. This issue will track the changes by markdown file,

API Specification

Design topics

Extensions

@steff456 steff456 added the Maintenance Bug fix, typo fix, or general maintenance. label Oct 12, 2021
@steff456 steff456 self-assigned this Oct 12, 2021
@xloem
Copy link

xloem commented Oct 23, 2021

idea:
specification held as python source with documented function stubs

  • easy to machine-read via import
  • sphinx already understands the format
  • might open possible implementation avenues such as inheritance or a reference implementation

@rgommers
Copy link
Member

specification held as python source with documented function stubs

Thanks for the suggestion @xloem. That is one of the options @steff456 is testing, it would indeed be a significant improvement over the .md files.

@xloem
Copy link

xloem commented Oct 25, 2021

I ended up hacking some quick py file generation at https://github.com/xloem/arrays to work with the spec in the repl help(). I was thinking of making a base class for something that plugged in api implementation fudges based on name matching with existing libraries

@rgommers
Copy link
Member

Thanks for sharing @xloem. That may be useful as an intermediate step; I'm hoping we end up with a more normal spec though which uses the numpydoc docstring format. So instead of:

Parameters
**********

*   **start**: *Union[ int, float ]*

it should look like:

Parameters
----------
start: Union[int, float]

@xloem
Copy link

xloem commented Oct 25, 2021

The source of the sphinx builder that outputs rst probably reveals what document elements might output that format, but if it's a one-way change a search+replace tool might be simpler.

@kgryte
Copy link
Contributor

kgryte commented Feb 7, 2022

@steff456 Now that this tracking issue is complete, can we close this out?

@kgryte kgryte modified the milestones: v2022, v2021 Feb 7, 2022
@steff456
Copy link
Member Author

steff456 commented Feb 7, 2022

I'm closing this issue given that all the specification is now in rst 🎉🎉🎉

@steff456 steff456 closed this as completed Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Bug fix, typo fix, or general maintenance.
Projects
None yet
Development

No branches or pull requests

4 participants