Skip to content

PR: Transform manipulation_functions.md to rst #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 31, 2022
Merged

PR: Transform manipulation_functions.md to rst #354

merged 2 commits into from
Jan 31, 2022

Conversation

steff456
Copy link
Member

This PR converts the manipulation functions markdown into rst

Ref: #283

@steff456 steff456 added the Maintenance Bug fix, typo fix, or general maintenance. label Dec 23, 2021
@steff456 steff456 added this to the v2022 milestone Dec 23, 2021
@steff456 steff456 requested review from rgommers and kgryte December 23, 2021 19:11
@steff456 steff456 self-assigned this Dec 23, 2021
@steff456 steff456 mentioned this pull request Dec 23, 2021
Closed
26 tasks
@rgommers rgommers modified the milestones: v2022, v2021 Jan 3, 2022
@asmeurer
Copy link
Member

I think this just has the question about the notes (#345 (comment)). It looks good otherwise.

@asmeurer
Copy link
Member

The notes directives still need to be updated here.

kgryte
kgryte approved these changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As the notes directives have been updated, will merge. Any additional changes can be performed in subsequent PRs.

@kgryte kgryte merged commit 28634c2 into data-apis:main Jan 31, 2022
@kgryte kgryte deleted the manipulation_functions-rst branch January 31, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

@rgommers rgommers Awaiting requested review from rgommers

Assignees

@steff456 steff456

Labels
Maintenance Bug fix, typo fix, or general maintenance.
Projects
None yet
Milestone
v2021
Development

Successfully merging this pull request may close these issues.
4 participants
@steff456 @asmeurer @kgryte @rgommers