-
Notifications
You must be signed in to change notification settings - Fork 53
PR: Convert array_object.md to rst #345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think the main question here is if we're OK with the notes in the various functions being replaced from If we're fine with this, I only have the one minor comment about a formatting issue. If not, we should change the "Notes" sections to use |
Just as a clarification, at the end I decided to compress all the notes in just one section because as we are using Numpy style documentation I'm unable to call the Edit: I found a way to do it 🎉 and updated this in the last commit |
Great. This looks good now. |
This PR converts the array object markdown into rst
Ref: #283
Note: It seems that the circleci redirector action only works if I open the PR from my own master branch. Given that I'm opening multiple PRs from branches, I'll update the link for the preview manually for each.
Preview: https://38-335160819-gh.circle-artifacts.com/0/build/latest/index.html