Skip to content

PR: Transform function and method signatures to rst #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 19, 2022

Conversation

steff456
Copy link
Member

This PR converts the function and method signatures markdown into rst

Ref: #283

@steff456 steff456 added the Maintenance Bug fix, typo fix, or general maintenance. label Dec 23, 2021
@steff456 steff456 added this to the v2022 milestone Dec 23, 2021
@steff456 steff456 requested review from rgommers and kgryte December 23, 2021 02:33
@steff456 steff456 self-assigned this Dec 23, 2021
@rgommers rgommers modified the milestones: v2022, v2021 Jan 3, 2022

Parameters
funcname(x1, x2, /, *, key1=-1, key2=None) -> out:
Parameters
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of this code block? Is it supposed to be to show an example of what the documentation in the spec looks like? If so, can we put this dummy function in the code and pull it in with autodoc? Though I honestly don't understand the point of having it at all if that's why it's there. If it's supposed to be to show what a valid function signature looks like, why not make this fully valid Python?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think is just to explain how function and method signatures are in the spec, this is the current example that is in the spec. What do you think about this @kgryte?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is already there, we can merge this without addressing it. But I do find this a bit confusing.

@asmeurer asmeurer merged commit 0ac0b0a into data-apis:main Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Bug fix, typo fix, or general maintenance.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants