Skip to content

PR: Transform set functions md to rst #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 31, 2022
Merged

PR: Transform set functions md to rst #369

merged 2 commits into from
Jan 31, 2022

Conversation

steff456
Copy link
Member

This PR transforms the set functions page from markdown to rst

Ref: #283

@steff456 steff456 added the Maintenance Bug fix, typo fix, or general maintenance. label Jan 19, 2022
@steff456 steff456 added this to the v2022 milestone Jan 19, 2022
@steff456 steff456 requested a review from asmeurer January 19, 2022 19:33
@steff456 steff456 self-assigned this Jan 19, 2022
@steff456 steff456 mentioned this pull request Jan 19, 2022
Closed
26 tasks
@kgryte kgryte modified the milestones: v2022, v2021 Jan 24, 2022
@asmeurer
Copy link
Member

The notes directives here still need to be updated.

kgryte
kgryte approved these changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As the notes directives have been updated, will merge. Can address any further issues in subsequent PRs.

@kgryte kgryte merged commit 36c6b75 into data-apis:main Jan 31, 2022
@kgryte kgryte deleted the setfunc-rst branch January 31, 2022 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

@asmeurer asmeurer Awaiting requested review from asmeurer

Assignees

@steff456 steff456

Labels
Maintenance Bug fix, typo fix, or general maintenance.
Projects
None yet
Milestone
v2021
Development

Successfully merging this pull request may close these issues.
3 participants
@steff456 @asmeurer @kgryte