Skip to content

PR: Transform broadcasting.md to .rst #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 18, 2022

Conversation

steff456
Copy link
Member

@steff456 steff456 commented Dec 15, 2021

This PR transforms the broadcasting page from markdown to rst

Ref: #283

Note: It seems that the circleci redirector action only works if I open the PR from my own master branch. Given that I'm opening multiple PRs from branches, I'll update the link for the preview manually for each.
Preview: https://48-335160819-gh.circle-artifacts.com/0/build/latest/index.html

@steff456 steff456 added this to the v2022 milestone Dec 15, 2021
@steff456 steff456 requested review from rgommers and kgryte December 15, 2021 17:09
@steff456 steff456 self-assigned this Dec 15, 2021
@steff456 steff456 added the Maintenance Bug fix, typo fix, or general maintenance. label Dec 15, 2021
@rgommers rgommers modified the milestones: v2022, v2021 Jan 3, 2022
@asmeurer
Copy link
Member

asmeurer commented Jan 3, 2022

It looks like the formatting here isn't actually working correctly for some of the code blocks.

For the pages that don't involve autosummary, I would suggest building the rst and markdown and comparing them side-by-side. They should both render identically if the conversion is done correctly.

@asmeurer
Copy link
Member

There are still some formatting issues here.

@asmeurer asmeurer merged commit 2c09526 into data-apis:main Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Bug fix, typo fix, or general maintenance.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants