Skip to content

PR: Transform linear algebra functions extension md to rst #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 3, 2022

Conversation

steff456
Copy link
Member

This PR transforms the linear algebra functions extension page from markdown to rst

Ref: #283

@steff456 steff456 added the Maintenance Bug fix, typo fix, or general maintenance. label Jan 27, 2022
@steff456 steff456 added this to the v2022 milestone Jan 27, 2022
@steff456 steff456 requested review from asmeurer and kgryte January 27, 2022 05:42
@steff456 steff456 self-assigned this Jan 27, 2022
@asmeurer
Copy link
Member

Autosummary failed in the build. I'm not clear why.

@asmeurer
Copy link
Member

Is it possible to name the file just linalg.py and have the function show up as linalg.cholesky, linalg.cross, and so on?

@asmeurer
Copy link
Member

The build passes for me locally.

@steff456
Copy link
Member Author

Autosummary failed in the build. I'm not clear why.

I think there's something weird with the python version, but I already fixed it on another PR. So once that's merged I hope the CIs are fixed here.

Is it possible to name the file just linalg.py and have the function show up as linalg.cholesky, linalg.cross, and so on?

Sure, I can change the name of the module

@asmeurer
Copy link
Member

Which other PR?

I'd like to get this merged as there as some fixed I want to make the linalg spec.

@steff456
Copy link
Member Author

Which other PR?

#367

@asmeurer
Copy link
Member

Everything looks good except for those comments.

@kgryte
Copy link
Contributor

kgryte commented Jan 31, 2022

@steff456 I believe #367 has already been merged. Are you able to resolve the merge conflict?

@asmeurer asmeurer merged commit 25e527c into data-apis:main Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Bug fix, typo fix, or general maintenance.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants