feat: MxNet 1.9 support #3042

ahsan-z-khan · 2022-03-31T23:15:12Z

Issue #, if available:

Description of changes:
Add image uris to support MxNet 1.9.0
Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2022-03-31T23:28:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 38bec3f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2022-03-31T23:32:38Z

Codecov Report

Merging #3042 (560c3d8) into master (4acbdb0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3042   +/-   ##
=======================================
  Coverage   89.62%   89.62%           
=======================================
  Files         200      200           
  Lines       17387    17387           
=======================================
  Hits        15583    15583           
  Misses       1804     1804

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4acbdb0...560c3d8. Read the comment docs.

sagemaker-bot · 2022-03-31T23:40:11Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 38bec3f
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-04-01T00:41:47Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: b624f22
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-04-01T01:36:27Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: b624f22
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-04-01T01:46:46Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: b624f22
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…" (aws#3041) This reverts commit e464689. Co-authored-by: Payton Staub <[email protected]>

Co-authored-by: Navin Soni <[email protected]>

* fix: Support file URIs in ProcessingStep's code parameter * Don't strip leading slash from file uri Co-authored-by: Payton Staub <[email protected]>

* feat: jumpstart model url * fix: jumpstart docs url * fix: jumpstart docstring * docs: add static datatable.js file * fix: docstring typo * fix: docstring capitalization

sagemaker-bot · 2022-04-07T19:13:13Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: c9a44cb
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-04-07T19:49:43Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: c9a44cb
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-04-07T19:52:18Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: d7b7727
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-04-07T19:53:40Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 7788c75
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-04-07T20:24:18Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: d7b7727
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-04-07T20:34:55Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 7788c75
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-04-07T20:49:32Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: d7b7727
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-04-07T20:49:34Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 7788c75
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-04-07T21:31:05Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: c9a44cb
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2022-04-22T01:48:31Z

@ahsan-z-khan do we need to add integ tests for this ?

sagemaker-bot · 2022-04-26T17:59:31Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 7788c75
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-04-26T18:09:26Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 7788c75
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-01T15:41:27Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 2b174c9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-01T16:01:44Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 2b174c9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-01T16:07:23Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 2b174c9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-01T16:21:51Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 2b174c9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-01T16:26:37Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 2b174c9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

navinsoni · 2022-06-01T17:19:15Z

tests/unit/test_mxnet.py

@@ -747,7 +747,7 @@ def test_model_prepare_container_def_no_instance_type_or_image(


 def test_attach(sagemaker_session, mxnet_training_version, mxnet_training_py_version):
-    if mxnet_training_py_version == "py37":
+    if mxnet_training_py_version == "py37" or mxnet_training_py_version == "py38":


nit: here you can change it as follows
if mxnet_training_py_version in ['py37', 'py38']:

sagemaker-bot · 2022-06-02T00:37:05Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 560c3d8
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-02T00:47:58Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 560c3d8
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-02T01:02:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 560c3d8
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-02T01:18:15Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 560c3d8
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-02T01:20:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 560c3d8
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

feat: MxNet 1.9 support

feat: MxNet 1.9 support

38bec3f

add unit tests

b624f22

staubhp and others added 15 commits April 7, 2022 11:46

Revert "fix: Fix Pipeline variables related customer issues (aws#2959)…

c76d309

…" (aws#3041) This reverts commit e464689. Co-authored-by: Payton Staub <[email protected]>

prepare release v2.82.2

ede4028

update development version to v2.82.3.dev0

d45885e

feature: Hugging Face Transformers 4.17 for TF 2.6 (aws#3027)

84190aa

Co-authored-by: Navin Soni <[email protected]>

fix: IOC image version select issue (aws#3021)

68d5e6f

Co-authored-by: Navin Soni <[email protected]>

prepare release v2.83.0

e00ffc9

update development version to v2.83.1.dev0

a0df095

feature: add xgboost framework version 1.5-1 (aws#3044)

101b985

feature: dependabot integ - move all deps to requirements.txt (aws#2981)

e230555

prepare release v2.84.0

44c729a

update development version to v2.84.1.dev0

db43f9c

feature: add serverless inference image_uri retrieve support (aws#3035)

c86feb3

Fix: remove old legacy code for web analytics (aws#3053)

4227655

fix: Support file URIs in ProcessingStep's code parameter (aws#3051)

a1e3f00

* fix: Support file URIs in ProcessingStep's code parameter * Don't strip leading slash from file uri Co-authored-by: Payton Staub <[email protected]>

feat: jumpstart model url (aws#3036)

c9a44cb

* feat: jumpstart model url * fix: jumpstart docs url * fix: jumpstart docstring * docs: add static datatable.js file * fix: docstring typo * fix: docstring capitalization

ahsan-z-khan added 2 commits April 7, 2022 12:24

Merge branch 'master' into mxnet-update

d7b7727

fix mxnet uri keys

7788c75

Merge branch 'master' into mxnet-update

2b174c9

mufaddal-rohawala approved these changes Jun 1, 2022

View reviewed changes

navinsoni reviewed Jun 1, 2022

View reviewed changes

changed some syntax

560c3d8

BasilBeirouti merged commit 60723ed into aws:master Jun 2, 2022

Lokiiiiii pushed a commit to Lokiiiiii/sagemaker-python-sdk that referenced this pull request Jun 2, 2022

feat: MxNet 1.9 support (aws#3042)

af7c2ed

feat: MxNet 1.9 support

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: MxNet 1.9 support #3042

feat: MxNet 1.9 support #3042

ahsan-z-khan commented Mar 31, 2022 •

edited

Loading

sagemaker-bot commented Mar 31, 2022

codecov-commenter commented Mar 31, 2022 •

edited

Loading

sagemaker-bot commented Mar 31, 2022

sagemaker-bot commented Apr 1, 2022

sagemaker-bot commented Apr 1, 2022

sagemaker-bot commented Apr 1, 2022

sagemaker-bot commented Apr 7, 2022

sagemaker-bot commented Apr 7, 2022

sagemaker-bot commented Apr 7, 2022

sagemaker-bot commented Apr 7, 2022

sagemaker-bot commented Apr 7, 2022

sagemaker-bot commented Apr 7, 2022

sagemaker-bot commented Apr 7, 2022

sagemaker-bot commented Apr 7, 2022

sagemaker-bot commented Apr 7, 2022

mufaddal-rohawala commented Apr 22, 2022

sagemaker-bot commented Apr 26, 2022

sagemaker-bot commented Apr 26, 2022

sagemaker-bot commented Jun 1, 2022

sagemaker-bot commented Jun 1, 2022

sagemaker-bot commented Jun 1, 2022

sagemaker-bot commented Jun 1, 2022

sagemaker-bot commented Jun 1, 2022

navinsoni Jun 1, 2022

sagemaker-bot commented Jun 2, 2022

sagemaker-bot commented Jun 2, 2022

sagemaker-bot commented Jun 2, 2022

sagemaker-bot commented Jun 2, 2022

sagemaker-bot commented Jun 2, 2022

feat: MxNet 1.9 support #3042

feat: MxNet 1.9 support #3042

Conversation

ahsan-z-khan commented Mar 31, 2022 • edited Loading

Merge Checklist

General

Tests

sagemaker-bot commented Mar 31, 2022

AWS CodeBuild CI Report

codecov-commenter commented Mar 31, 2022 • edited Loading

Codecov Report

sagemaker-bot commented Mar 31, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Apr 1, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Apr 1, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Apr 1, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Apr 7, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Apr 7, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Apr 7, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Apr 7, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Apr 7, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Apr 7, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Apr 7, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Apr 7, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Apr 7, 2022

AWS CodeBuild CI Report

mufaddal-rohawala commented Apr 22, 2022

sagemaker-bot commented Apr 26, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Apr 26, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jun 1, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jun 1, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jun 1, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jun 1, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jun 1, 2022

AWS CodeBuild CI Report

navinsoni Jun 1, 2022

Choose a reason for hiding this comment

sagemaker-bot commented Jun 2, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jun 2, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jun 2, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jun 2, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jun 2, 2022

AWS CodeBuild CI Report

ahsan-z-khan commented Mar 31, 2022 •

edited

Loading

codecov-commenter commented Mar 31, 2022 •

edited

Loading