Revert "fix: Fix Pipeline variables related customer issues (#2959)" #3041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e464689.
Codecov Report
@@ Coverage Diff @@
## master #3041 +/- ##
==========================================
- Coverage 89.39% 89.39% -0.01%
==========================================
Files 196 196
Lines 16650 16656 +6
==========================================
+ Hits 14885 14890 +5
- Misses 1765 1766 +1
Continue to review full report at Codecov.
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
qidewenwhen
approved these changes
Mar 31, 2022
ahsan-z-khan
approved these changes
Mar 31, 2022
shreyapandit
approved these changes
Mar 31, 2022
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
qidewenwhen
pushed a commit
to qidewenwhen/sagemaker-python-sdk
that referenced
this pull request
Apr 2, 2022
9 tasks
qidewenwhen
pushed a commit
to qidewenwhen/sagemaker-python-sdk
that referenced
this pull request
Apr 5, 2022
ahsan-z-khan
pushed a commit
to ahsan-z-khan/sagemaker-python-sdk
that referenced
this pull request
Apr 7, 2022
…" (aws#3041) This reverts commit e464689. Co-authored-by: Payton Staub <[email protected]>
qidewenwhen
pushed a commit
to qidewenwhen/sagemaker-python-sdk
that referenced
this pull request
Apr 7, 2022
ahsan-z-khan
pushed a commit
that referenced
this pull request
Apr 7, 2022
…3043) * Revert "Revert "fix: Fix Pipeline variables related customer issues (#2959)" (#3041)" This reverts commit 2782f8c. * fix: Include deprecated JsonGet into PipelineVariable Co-authored-by: Dewen Qi <[email protected]>
jerrypeng7773
pushed a commit
to jerrypeng7773/sagemaker-python-sdk
that referenced
this pull request
May 13, 2022
…" (aws#3041) This reverts commit e464689. Co-authored-by: Payton Staub <[email protected]>
jerrypeng7773
pushed a commit
to jerrypeng7773/sagemaker-python-sdk
that referenced
this pull request
May 13, 2022
…ws#3043) * Revert "Revert "fix: Fix Pipeline variables related customer issues (aws#2959)" (aws#3041)" This reverts commit 2782f8c. * fix: Include deprecated JsonGet into PipelineVariable Co-authored-by: Dewen Qi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit e464689.
Issue #, if available:
N/A
Description of changes:
Deprecated version of JsonGet is throwing pickle errors. Revert this change to avoid impacting users using the deprecated function.
Testing done:
Unit, manual
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_baseto create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.