Skip to content

fix: Fix Pipeline variables related customer issues #2959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2022
Merged

fix: Fix Pipeline variables related customer issues #2959

merged 1 commit into from
Mar 30, 2022

Conversation

qidewenwhen
Copy link
Member

@qidewenwhen qidewenwhen commented Feb 25, 2022 •
edited
Loading

Issue #, if available: E.g. #2791

Description of changes: Fix all existing customer reported issues related to SageMaker Pipeline variables (i.e. Parameter, Properties, ExecutionVariable, functions like Join and JsonGet).
The issues are collected from GitHub issues or internal channels.

Testing done: unit tests and integ tests

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2022 •
edited
Loading

Codecov Report

Merging #2959 (1404136) into master (30b4ce2) will increase coverage by 0.00%.
The diff coverage is 94.73%.

@@           Coverage Diff           @@
##           master    #2959   +/-   ##
=======================================
  Coverage   89.33%   89.34%           
=======================================
  Files         196      196           
  Lines       16645    16639    -6     
=======================================
- Hits        14870    14866    -4     
+ Misses       1775     1773    -2
Impacted Files Coverage Δ
src/sagemaker/tuner.py 98.12% <ø> (+0.20%) ⬆️
src/sagemaker/workflow/_repack_model.py 100.00% <ø> (ø)
src/sagemaker/session.py 70.47% <66.66%> (+0.07%) ⬆️
src/sagemaker/estimator.py 91.30% <100.00%> (ø)
src/sagemaker/model.py 92.13% <100.00%> (+0.02%) ⬆️
src/sagemaker/processing.py 96.10% <100.00%> (+0.02%) ⬆️
src/sagemaker/tensorflow/model.py 90.32% <100.00%> (+0.10%) ⬆️
src/sagemaker/workflow/_utils.py 87.39% <100.00%> (-0.51%) ⬇️
src/sagemaker/workflow/airflow.py 91.55% <100.00%> (ø)
src/sagemaker/workflow/clarify_check_step.py 97.48% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30b4ce2...1404136. Read the comment docs.

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: cc4fdea
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: cc4fdea
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: cc4fdea
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 9be4036
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 134c6ac
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 9be4036
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 134c6ac
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 9be4036
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

navaj0
navaj0 approved these changes Feb 26, 2022
View reviewed changes
@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 43fde80
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 43fde80
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 43fde80
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@qidewenwhen qidewenwhen force-pushed the dev branch 2 times, most recently from affca81 to 64b5f51 Compare March 4, 2022 02:03
@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: affca81
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: affca81
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: affca81
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@qidewenwhen qidewenwhen removed the request for review from jerrypeng7773 March 4, 2022 02:20
@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 64b5f51
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 64b5f51
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 64b5f51
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 7b8c470
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: f6963c6
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: f6963c6
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 3301c8f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 3301c8f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 3301c8f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 3301c8f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

fix: Fix Pipeline variables related customer issues
1404136 
fix: Prevent passing pipeline variables as code arg in ProcessingStep in compile time
@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 6abebcf
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 1404136
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 6abebcf
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 1404136
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 1404136
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 6abebcf
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@navinsoni navinsoni merged commit e464689 into aws:master Mar 30, 2022
mufaddal-rohawala
mufaddal-rohawala reviewed Mar 30, 2022
View reviewed changes
tests/integ/sagemaker/workflow/test_tuning_steps.py
rf"arn:aws:sagemaker:{region_name}:\d{{12}}:pipeline/{pipeline_name}/execution/",
execution.arn,
)
for _ in retries(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Thanks for adding retries, do we feel the need to add retries for other integ tests added above?

staubhp pushed a commit to staubhp/sagemaker-python-sdk that referenced this pull request Mar 31, 2022
Revert "fix: Fix Pipeline variables related customer issues (aws#2959)"
ea0d3f9 
This reverts commit e464689.
ahsan-z-khan pushed a commit that referenced this pull request Apr 1, 2022
@staubhp
Revert "fix: Fix Pipeline variables related customer issues (#2959)" (#…
2782f8c 
…3041)

This reverts commit e464689.

Co-authored-by: Payton Staub <[email protected]>
qidewenwhen pushed a commit to qidewenwhen/sagemaker-python-sdk that referenced this pull request Apr 2, 2022
Revert "Revert "fix: Fix Pipeline variables related customer issues (a…
f2a9e02 
…ws#2959)" (aws#3041)"

This reverts commit 2782f8c.
@qidewenwhen qidewenwhen mentioned this pull request Apr 2, 2022
Merged
9 tasks
qidewenwhen pushed a commit to qidewenwhen/sagemaker-python-sdk that referenced this pull request Apr 5, 2022
Revert "Revert "fix: Fix Pipeline variables related customer issues (a…
b1a530a 
…ws#2959)" (aws#3041)"

This reverts commit 2782f8c.
ahsan-z-khan pushed a commit to ahsan-z-khan/sagemaker-python-sdk that referenced this pull request Apr 7, 2022
@staubhp @ahsan-z-khan
Revert "fix: Fix Pipeline variables related customer issues (aws#2959)…
c76d309 
…" (aws#3041)

This reverts commit e464689.

Co-authored-by: Payton Staub <[email protected]>
qidewenwhen pushed a commit to qidewenwhen/sagemaker-python-sdk that referenced this pull request Apr 7, 2022
@qidewenwhen
Revert "Revert "fix: Fix Pipeline variables related customer issues (a…
9229ebd 
…ws#2959)" (aws#3041)"

This reverts commit 2782f8c.
ahsan-z-khan pushed a commit that referenced this pull request Apr 7, 2022
@qidewenwhen
fix: Add back the Fix for Pipeline variables related customer issues (#…
6ffe925 
…3043)

* Revert "Revert "fix: Fix Pipeline variables related customer issues (#2959)" (#3041)"

This reverts commit 2782f8c.

* fix: Include deprecated JsonGet into PipelineVariable

Co-authored-by: Dewen Qi <[email protected]>
jerrypeng7773 pushed a commit to jerrypeng7773/sagemaker-python-sdk that referenced this pull request May 13, 2022
@qidewenwhen @jerrypeng7773
fix: Fix Pipeline variables related customer issues (aws#2959)
21dcf1c 
Co-authored-by: Dewen Qi <[email protected]>
jerrypeng7773 pushed a commit to jerrypeng7773/sagemaker-python-sdk that referenced this pull request May 13, 2022
@staubhp @jerrypeng7773
Revert "fix: Fix Pipeline variables related customer issues (aws#2959)…
95689bb 
…" (aws#3041)

This reverts commit e464689.

Co-authored-by: Payton Staub <[email protected]>
jerrypeng7773 pushed a commit to jerrypeng7773/sagemaker-python-sdk that referenced this pull request May 13, 2022
@qidewenwhen @jerrypeng7773
fix: Add back the Fix for Pipeline variables related customer issues (a…
4f58f92 
…ws#3043)

* Revert "Revert "fix: Fix Pipeline variables related customer issues (aws#2959)" (aws#3041)"

This reverts commit 2782f8c.

* fix: Include deprecated JsonGet into PipelineVariable

Co-authored-by: Dewen Qi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mufaddal-rohawala mufaddal-rohawala mufaddal-rohawala left review comments

@shreyapandit shreyapandit shreyapandit approved these changes

@navinsoni navinsoni navinsoni approved these changes

@staubhp staubhp staubhp approved these changes

@navaj0 navaj0 navaj0 approved these changes

@jerrypeng7773 jerrypeng7773 jerrypeng7773 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@qidewenwhen @codecov-commenter @sagemaker-bot @shreyapandit @navinsoni @staubhp @navaj0 @jerrypeng7773 @mufaddal-rohawala