Skip to content

Commit 60723ed

Browse files
authored
feat: MxNet 1.9 support (#3042)
feat: MxNet 1.9 support
1 parent 62eee2a commit 60723ed

File tree

3 files changed

+73
-3
lines changed

3 files changed

+73
-3
lines changed

src/sagemaker/image_uri_config/mxnet.json

Lines changed: 68 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@
1010
"1.4": "1.4.1",
1111
"1.6": "1.6.0",
1212
"1.7": "1.7.0",
13-
"1.8": "1.8.0"
13+
"1.8": "1.8.0",
14+
"1.9": "1.9.0"
1415
},
1516
"versions": {
1617
"0.12.1": {
@@ -346,6 +347,37 @@
346347
},
347348
"repository": "mxnet-training",
348349
"py_versions": ["py37"]
350+
},
351+
"1.9.0": {
352+
"registries": {
353+
"af-south-1": "626614931356",
354+
"ap-east-1": "871362719292",
355+
"ap-northeast-1": "763104351884",
356+
"ap-northeast-2": "763104351884",
357+
"ap-northeast-3": "364406365360",
358+
"ap-south-1": "763104351884",
359+
"ap-southeast-1": "763104351884",
360+
"ap-southeast-2": "763104351884",
361+
"ca-central-1": "763104351884",
362+
"cn-north-1": "727897471807",
363+
"cn-northwest-1": "727897471807",
364+
"eu-central-1": "763104351884",
365+
"eu-north-1": "763104351884",
366+
"eu-west-1": "763104351884",
367+
"eu-west-2": "763104351884",
368+
"eu-west-3": "763104351884",
369+
"eu-south-1": "692866216735",
370+
"me-south-1": "217643126080",
371+
"sa-east-1": "763104351884",
372+
"us-east-1": "763104351884",
373+
"us-east-2": "763104351884",
374+
"us-gov-west-1": "442386744353",
375+
"us-iso-east-1": "886529160074",
376+
"us-west-1": "763104351884",
377+
"us-west-2": "763104351884"
378+
},
379+
"repository": "mxnet-training",
380+
"py_versions": ["py38"]
349381
}
350382
}
351383
},
@@ -358,7 +390,10 @@
358390
"1.2": "1.2.1",
359391
"1.3": "1.3.0",
360392
"1.4": "1.4.1",
361-
"1.6": "1.6.0"
393+
"1.6": "1.6.0",
394+
"1.7": "1.7.0",
395+
"1.8": "1.8.0",
396+
"1.9": "1.9.0"
362397
},
363398
"versions": {
364399
"0.12.1": {
@@ -694,6 +729,37 @@
694729
},
695730
"repository": "mxnet-inference",
696731
"py_versions": ["py37"]
732+
},
733+
"1.9.0": {
734+
"registries": {
735+
"af-south-1": "626614931356",
736+
"ap-east-1": "871362719292",
737+
"ap-northeast-1": "763104351884",
738+
"ap-northeast-2": "763104351884",
739+
"ap-northeast-3": "364406365360",
740+
"ap-south-1": "763104351884",
741+
"ap-southeast-1": "763104351884",
742+
"ap-southeast-2": "763104351884",
743+
"ca-central-1": "763104351884",
744+
"cn-north-1": "727897471807",
745+
"cn-northwest-1": "727897471807",
746+
"eu-central-1": "763104351884",
747+
"eu-north-1": "763104351884",
748+
"eu-west-1": "763104351884",
749+
"eu-west-2": "763104351884",
750+
"eu-west-3": "763104351884",
751+
"eu-south-1": "692866216735",
752+
"me-south-1": "217643126080",
753+
"sa-east-1": "763104351884",
754+
"us-east-1": "763104351884",
755+
"us-east-2": "763104351884",
756+
"us-gov-west-1": "442386744353",
757+
"us-iso-east-1": "886529160074",
758+
"us-west-1": "763104351884",
759+
"us-west-2": "763104351884"
760+
},
761+
"repository": "mxnet-inference",
762+
"py_versions": ["py38"]
697763
}
698764
}
699765
},

tests/conftest.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -181,6 +181,8 @@ def mxnet_inference_py_version(mxnet_inference_version, request):
181181
return request.param
182182
elif Version(mxnet_inference_version) == Version("1.8.0"):
183183
return "py37"
184+
elif Version(mxnet_inference_version) == Version("1.9.0"):
185+
return "py38"
184186
else:
185187
return "py3"
186188

@@ -191,6 +193,8 @@ def mxnet_training_py_version(mxnet_training_version, request):
191193
return request.param
192194
elif Version(mxnet_training_version) == Version("1.8.0"):
193195
return "py37"
196+
elif Version(mxnet_training_version) == Version("1.9.0"):
197+
return "py38"
194198
else:
195199
return "py3"
196200

tests/unit/test_mxnet.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -747,7 +747,7 @@ def test_model_prepare_container_def_no_instance_type_or_image(
747747

748748

749749
def test_attach(sagemaker_session, mxnet_training_version, mxnet_training_py_version):
750-
if mxnet_training_py_version == "py37":
750+
if mxnet_training_py_version in ["py37", "py38"]:
751751
training_image = "1.dkr.ecr.us-west-2.amazonaws.com/mxnet-training:{1}-cpu-{0}".format(
752752
mxnet_training_py_version, mxnet_training_version
753753
)

0 commit comments

Comments
 (0)