-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix: Support file URIs in ProcessingStep's code parameter #3051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aoguo64
approved these changes
Apr 6, 2022
jerrypeng7773
approved these changes
Apr 6, 2022
rohangujarathi
approved these changes
Apr 6, 2022
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
ahsan-z-khan
approved these changes
Apr 6, 2022
nmadan
approved these changes
Apr 7, 2022
navinsoni
approved these changes
Apr 7, 2022
ahsan-z-khan
pushed a commit
to ahsan-z-khan/sagemaker-python-sdk
that referenced
this pull request
Apr 7, 2022
* fix: Support file URIs in ProcessingStep's code parameter * Don't strip leading slash from file uri Co-authored-by: Payton Staub <[email protected]>
jerrypeng7773
pushed a commit
to jerrypeng7773/sagemaker-python-sdk
that referenced
this pull request
May 13, 2022
* fix: Support file URIs in ProcessingStep's code parameter * Don't strip leading slash from file uri Co-authored-by: Payton Staub <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
ProcessingStep hashes the contents of local files passed to
code
to fix cache miss issues. Update the hash function to support file URIs.Testing done:
Unit, manual
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_base
to create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.