feature: dependabot integ - move all deps to requirements.txt #2981

mufaddal-rohawala · 2022-03-09T02:14:45Z

Issue #, if available:
https://issues.amazon.com/issues/V534089506

Description of changes:
Dependabot currently does not track extras and tox.ini dependencies. This PR helps track the dependencies for security alerts. The changes are backwards compatible.

Testing done:
Ran unit tests locally. Also checked manual runs for: pip install -e .'[local]' , etc.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-commenter · 2022-03-09T02:33:46Z

Codecov Report

Merging #2981 (96e4685) into master (80c3c13) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2981      +/-   ##
==========================================
- Coverage   89.47%   89.39%   -0.08%     
==========================================
  Files        1028      196     -832     
  Lines       84148    16656   -67492     
==========================================
- Hits        75288    14890   -60398     
+ Misses       8860     1766    -7094

Impacted Files	Coverage Δ
...n3.9/site-packages/sagemaker/workflow/functions.py
...agemaker/model_monitor/clarify_model_monitoring.py
...hon3.7/site-packages/sagemaker/tensorflow/model.py
...python3.6/site-packages/sagemaker/pytorch/model.py
...thon3.8/site-packages/sagemaker/jumpstart/types.py
...ib/python3.8/site-packages/sagemaker/processing.py
...n3.6/site-packages/sagemaker/wrangler/ingestion.py
...ite-packages/sagemaker/training_compiler/config.py
...ython3.9/site-packages/sagemaker/lineage/_utils.py
...gemaker/cli/compatibility/v2/modifiers/modifier.py
... and 823 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80c3c13...96e4685. Read the comment docs.

sagemaker-bot · 2022-03-09T02:39:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: d9b7222
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-09T03:06:25Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: d9b7222
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-09T04:06:48Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: d9b7222
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-18T01:07:03Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 0c1d66e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-18T01:42:57Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 0c1d66e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-18T03:01:11Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 0c1d66e
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-04-03T02:49:02Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 853ba9c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-04-03T03:36:37Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 853ba9c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

navinsoni

is there a specific reason we have coverage in multiple files

requirements/tox/clean_requirements.txt
requirements/tox/coverage_requirements.txt

setup.py

requirements/tox/mypy_requirements.txt

requirements/tox/spelling_requirements.txt

requirements/extras/test_requirements.txt

sagemaker-bot · 2022-04-04T22:34:48Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 2158c3c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-04-04T23:04:16Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 2158c3c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-04-04T23:58:53Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 2158c3c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-04-05T01:01:35Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 96e4685
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-04-05T01:52:15Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 96e4685
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

ahsan-z-khan approved these changes Mar 12, 2022

View reviewed changes

jeniyat approved these changes Mar 13, 2022

View reviewed changes

ahsan-z-khan changed the base branch from dev to master March 15, 2022 16:44

mufaddal-rohawala force-pushed the dependabot-integ branch from d9b7222 to 0c1d66e Compare March 18, 2022 00:46

mufaddal-rohawala added 2 commits April 2, 2022 19:19

feature: dependabot integ - move all deps to requirements.txt

66e1c0e

fix: black-check errors

853ba9c

mufaddal-rohawala force-pushed the dependabot-integ branch from 0c1d66e to 853ba9c Compare April 3, 2022 02:20

navinsoni suggested changes Apr 4, 2022

View reviewed changes

navinsoni reviewed Apr 4, 2022

View reviewed changes

setup.py Outdated Show resolved Hide resolved

navinsoni reviewed Apr 4, 2022

View reviewed changes

requirements/tox/mypy_requirements.txt Outdated Show resolved Hide resolved

navinsoni reviewed Apr 4, 2022

View reviewed changes

requirements/tox/spelling_requirements.txt Outdated Show resolved Hide resolved

navinsoni reviewed Apr 4, 2022

View reviewed changes

requirements/extras/test_requirements.txt Show resolved Hide resolved

fix: add fixes per feedback

2158c3c

fix: add fixes per feedback

96e4685

navinsoni approved these changes Apr 5, 2022

View reviewed changes

ahsan-z-khan merged commit 6ce11cb into aws:master Apr 5, 2022

ahsan-z-khan pushed a commit to ahsan-z-khan/sagemaker-python-sdk that referenced this pull request Apr 7, 2022

feature: dependabot integ - move all deps to requirements.txt (aws#2981)

e230555

jerrypeng7773 pushed a commit to jerrypeng7773/sagemaker-python-sdk that referenced this pull request May 13, 2022

feature: dependabot integ - move all deps to requirements.txt (aws#2981)

bd13900

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature: dependabot integ - move all deps to requirements.txt #2981

feature: dependabot integ - move all deps to requirements.txt #2981

mufaddal-rohawala commented Mar 9, 2022 •

edited

Loading

codecov-commenter commented Mar 9, 2022 •

edited

Loading

sagemaker-bot commented Mar 9, 2022

sagemaker-bot commented Mar 9, 2022

sagemaker-bot commented Mar 9, 2022

sagemaker-bot commented Mar 18, 2022

sagemaker-bot commented Mar 18, 2022

sagemaker-bot commented Mar 18, 2022

sagemaker-bot commented Apr 3, 2022

sagemaker-bot commented Apr 3, 2022

navinsoni left a comment

sagemaker-bot commented Apr 4, 2022

sagemaker-bot commented Apr 4, 2022

sagemaker-bot commented Apr 4, 2022

sagemaker-bot commented Apr 5, 2022

sagemaker-bot commented Apr 5, 2022

feature: dependabot integ - move all deps to requirements.txt #2981

feature: dependabot integ - move all deps to requirements.txt #2981

Conversation

mufaddal-rohawala commented Mar 9, 2022 • edited Loading

Merge Checklist

General

Tests

codecov-commenter commented Mar 9, 2022 • edited Loading

Codecov Report

sagemaker-bot commented Mar 9, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Mar 9, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Mar 9, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Mar 18, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Mar 18, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Mar 18, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Apr 3, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Apr 3, 2022

AWS CodeBuild CI Report

navinsoni left a comment

Choose a reason for hiding this comment

sagemaker-bot commented Apr 4, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Apr 4, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Apr 4, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Apr 5, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Apr 5, 2022

AWS CodeBuild CI Report

mufaddal-rohawala commented Mar 9, 2022 •

edited

Loading

codecov-commenter commented Mar 9, 2022 •

edited

Loading