-
Notifications
You must be signed in to change notification settings - Fork 415
Reorganizing vtr_flow/tasks #1728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganizing vtr_flow/tasks #1728
Conversation
All tasks except for power_quick need to have their golden_results be checked.
@ArashAhmadian Thanks for getting this done. I think you are missing something (maybe you forgot to compile vpr) before running the tasks and generating the golden_solution as all the runs errored out and the golden solutions are empty. Please revisit this. |
Looks like |
Looks like |
|
|
|
|
There still seems to be a lot of files being saved;
|
|
Thanks @mithro. I updated Regarding the unexpected run-time of |
|
Thanks @ArashAhmadian . The changes look good; waiting for CI to go green before merging. |
I have added a README_nightly_regression_parallelism.md under regression_tests which goes over the strategy behind the 3 way split and how to add tests. Would you prefer for this description to be added or moved to the doc? |
@vaughnbetz All CI tests passed. Updating golden results for the FIR_filters & FIR_filters_frac seemed to have fixed the qor fails. |
@ArashAhmadian I was looking at the results from the nightly tests and I may have missed it but I think that the |
@ArashAhmadian : I like the new README and think it should be included. |
Looks like the Nightly tests are succeeding now? |
@ArashAhmadian : I did a quick search for the symbiflow config being run in the nightly regtests (all 3 sub-tests) and didn't find it. So it does look like it has gone AWOL. This is the old path to it: https://github.com/verilog-to-routing/vtr-verilog-to-routing/tree/master/vtr_flow/tasks/regression_tests/vtr_reg_nightly/symbiflow/config |
@acomodi Thanks for pointing this out. I have added the |
Nice work Arash! This is a big improvement in our test coverage and turnaround time. |
Thanks! 🙂 |
Reorganized vtr-tasks by removing/moving the outdated tasks not run in CI.
Description
Deleted tasks: timing_small,timing_chain,checkin_reg,basic_flow,regression_bidir, regression_fpu_hard_block_arch,regression_fpu_soft_block_arch
Moved tasks:arithmetic_tasks,func_multiclock,power,multiclock_mcnc to vtr_reg_weekly
timing to vtr_reg_nightly,regression_mcnc to vtr_reg_basic
Motivation and Context
To make sure that all the tasks are updated by being included in the CI and deleting outdated ones.