Updating docs to mention vtr_reg_nightly parallelism strategy #1776
Conversation
|
@vaughnbetz the doc additions are ready for review. |
ArashAhmadian
changed the title
README.developers.md
Outdated
| **Feature Coverage:** Medium | ||
|
|
||
| **Benchmarks:** Small-medium size, diverse. Includes: | ||
|
|
||
| * VTR benchmarks | ||
| * Titan 'other' benchmarks (smaller than Titan23) |
There was a problem hiding this comment.
Doesn't it include most of the titan23 benchmarks too?
There was a problem hiding this comment.
I think this documentation could be refactored to be shorter. State all the things that pertain to all vtr_nightly tests together, and then state only the details that are different for each sub-test. Essentially these comprise one set of tests that should be checked before a PR (and are checked by CI) but they are split into sub-suites for more parallel execution during CI.
There was a problem hiding this comment.
Sure. I made changes based on the suggestions
|
Mostly good, but please see my comments above about refactoring the vtr_reg_nightly part of README_developers.md to be shorter (avoid repeating things 3 times and highlight that vtr_reg_nightlyX are all related). |
|
@vaughnbetz The new changes are ready for review. |
|
Looks good; thanks Arash. |
Description
Updated README.developers.md to go over parallelism strategy and give detailed steps for adding new suites.
Motivation and Context
To update the document to be inline with #1728.
Types of changes
Checklist: