Skip to content

I v5 develop 24 aug #4803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 35 commits into from
Aug 24, 2020
Merged

I v5 develop 24 aug #4803

merged 35 commits into from
Aug 24, 2020

Conversation

sushilshinde
Copy link
Collaborator

No description provided.

cagdas001 and others added 30 commits August 11, 2020 12:00
Fix for MOST_RECENT, TIME_TO_REGISTER and TIME_TO_SUBMIT sortings.
  * Since the V5 API  returns inconistent values for
    (`registrationStartDate`, `registrationEndDate`, `submissionStartDate`, `submissionEndDate`),
    these dates will now be extracted from `challenge.phases` array.

Reference #4715, #4716
fix(challenge-listing): sorting functions
* Add `phaseStartDate` and `phaseEndDate` helper functions at `challenge-detail/helper`
to get the correct start/end date of a phase.
* `TIME_TO_REGISTER`, `TIME_TO_SUBMIT` and `MOST_RECENT` sorting functions updated to reflect above change.
* `ProgressBarTooltip` and `ChallengeCard/Status` updated to display correct phase start/end dates.

Addresses #4715, #4716
updated isZurichCompetitor to use group 'oldId' instead 'id'
Redirect /challenge/legacyId/submit to /challenge/UUID/submit
fix(challenge-listing): `CURRENT_PHASE` sorting
Challenge Details - Fix submissions memberHandle
@sushilshinde sushilshinde requested a review from ajefts as a code owner August 24, 2020 09:27
@sushilshinde sushilshinde merged commit 11a9cec into develop Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants