Skip to content

[$50]Challenge Listing: Ongoing challenges Sort by Current phase does not work as expected #4129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SathyaJayabal opened this issue Mar 23, 2020 · 16 comments

Comments

@SathyaJayabal
Copy link
Collaborator

Go to challenge listing
select Ongoing Challenges filter
select "Sort by Current Phase"

actual: the results are not sorted by the current phase
expected: the results must be sorted by current phase

Note: unable to add attachments. will upload later

@SathyaJayabal
Copy link
Collaborator Author

Screenshot 2020-06-22 at 4 19 02 PM

@SathyaJayabal SathyaJayabal added P2 Important (resolve within 3 days) v5-intgration-sub-code labels Jul 23, 2020
@SathyaJayabal
Copy link
Collaborator Author

@sushilshinde @Oanh-and-only-Oanh ,can we address this too with the v5 challenge-api release. The sorting is not working correctly in the v5 integration too. cc @lakshmiathreya
Screenshot 2020-07-23 at 2 43 28 PM

@Oanh-and-only-Oanh
Copy link

@SathyaJayabal, i think P2 is the right label for this one. Since we're not going to PROD until Aug. 3, we might be able to get this resolved with the first release. @sushilshinde

@SathyaJayabal SathyaJayabal added this to the V5 Challenge API v1.1 milestone Aug 13, 2020
@sushilshinde sushilshinde changed the title Challenge Listing: Ongoing challenges Sort by Current phase does not work as expected [$50]Challenge Listing: Ongoing challenges Sort by Current phase does not work as expected Aug 17, 2020
@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30137529 has been created for this ticket.

This is an automated message for crazyk via Topcoder X

@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30137529 has been updated - it has been assigned to cagdas001.

This is an automated message for crazyk via Topcoder X

@cagdas001
Copy link
Collaborator

PR: #4772

@sushilshinde
Copy link
Collaborator

Thanks, some technicical problem with the staging environemnts PR so not merged.

@lakshmiathreya
Copy link

Current Phase Alphabetical Sorting is working as expected in Staging.
Screenshot 2020-08-20 at 10 05 09 PM
Screenshot 2020-08-20 at 10 05 32 PM
Not working in V4 and Prod (V5):
Screenshot 2020-08-20 at 10 06 13 PM
Screenshot 2020-08-20 at 10 06 24 PM

@SathyaJayabal
Copy link
Collaborator Author

SathyaJayabal commented Aug 24, 2020

@Oanh-and-only-Oanh @sushilshinde @lakshmiathreya , what is the requirement for sort by current phase?

  1. Is it alphabetical sort by phase name
    OR
  2. Sort based on order in which phases are run. Example:
    a. Registration
    b. Checkpoint Submission
    c. Submission
    d. Checkpoint review
    e. Review/ Iterative Review
    f. Appeals
    g. Appeals Response
    h. Final Fix
    h Approval
    i. Post Mortem

@SathyaJayabal SathyaJayabal added the Need clarification Need clarification to proceed fixing the issue further label Aug 24, 2020
@lakshmiathreya
Copy link

@SathyaJayabal the fix seems to be for Alphabetical order ...

@cagdas001
Copy link
Collaborator

@lakshmiathreya @SathyaJayabal Yes, the fix is Alphabetical order. The old implementation was using the Alphabetical order, so I followed the same thing.

@SathyaJayabal
Copy link
Collaborator Author

@cagdas001 , if the old implementation was using alphabetical order, then we are good.

@SathyaJayabal SathyaJayabal removed the Need clarification Need clarification to proceed fixing the issue further label Aug 24, 2020
@cagdas001
Copy link
Collaborator

@SathyaJayabal Yes, it was sorting in alphabetical order, can be seen here: https://github.com/topcoder-platform/community-app/pull/4772/files#diff-6c236f955a26f5eacaad6b5b079bdd63L24

Though, IMHO, this sorting might not be good for UX, but, since the old implementation was using this I followed the same.

You can discuss your proposal (I think it's better for UX) with team and if it's allowed I can change the sorting

Sort based on order in which phases are run. Example:
a. Registration
b. Checkpoint Submission
c. Submission
d. Checkpoint review
e. Review/ Iterative Review
f. Appeals
g. Appeals Response
h. Final Fix
h Approval
i. Post Mortem

@SathyaJayabal
Copy link
Collaborator Author

@cagdas001 , you are right about the UX. If there is a change, we will do it as an enhancement in a separate ticket.

@lakshmiathreya lakshmiathreya added the QA Pass in PROD Passed verification on Production label Aug 24, 2020
@lakshmiathreya
Copy link

Alpha sort working fine in Prod.

@crazyk07
Copy link

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30137529

This is an automated message for crazyk via Topcoder X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants