-
Notifications
You must be signed in to change notification settings - Fork 212
[$50]Challenge Listing: Ongoing challenges Sort by Current phase does not work as expected #4129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@sushilshinde @Oanh-and-only-Oanh ,can we address this too with the v5 challenge-api release. The sorting is not working correctly in the v5 integration too. cc @lakshmiathreya |
@SathyaJayabal, i think P2 is the right label for this one. Since we're not going to PROD until Aug. 3, we might be able to get this resolved with the first release. @sushilshinde |
Contest https://www.topcoder.com/challenges/30137529 has been created for this ticket. |
Contest https://www.topcoder.com/challenges/30137529 has been updated - it has been assigned to cagdas001. |
PR: #4772 |
Thanks, some technicical problem with the staging environemnts PR so not merged. |
@Oanh-and-only-Oanh @sushilshinde @lakshmiathreya , what is the requirement for sort by current phase?
|
@SathyaJayabal the fix seems to be for Alphabetical order ... |
@lakshmiathreya @SathyaJayabal Yes, the fix is Alphabetical order. The old implementation was using the Alphabetical order, so I followed the same thing. |
@cagdas001 , if the old implementation was using alphabetical order, then we are good. |
@SathyaJayabal Yes, it was sorting in alphabetical order, can be seen here: https://github.com/topcoder-platform/community-app/pull/4772/files#diff-6c236f955a26f5eacaad6b5b079bdd63L24 Though, IMHO, this sorting might not be good for UX, but, since the old implementation was using this I followed the same. You can discuss your proposal (I think it's better for UX) with team and if it's allowed I can change the sorting
|
@cagdas001 , you are right about the UX. If there is a change, we will do it as an enhancement in a separate ticket. |
Alpha sort working fine in Prod. |
Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30137529 |
Go to challenge listing
select Ongoing Challenges filter
select "Sort by Current Phase"
actual: the results are not sorted by the current phase
expected: the results must be sorted by current phase
Note: unable to add attachments. will upload later
The text was updated successfully, but these errors were encountered: