Skip to content

[$50]Sort by: Time to submit and Time to register does not work as expected #4715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SathyaJayabal opened this issue Aug 6, 2020 · 21 comments

Comments

@SathyaJayabal
Copy link
Collaborator

The following sort functionalities on the challenge listings page does not work as expected.
My Challenges bucket: Time to Submit
Open for registration bucket: Time to Submit, Time to Register

Screenshot 2020-08-06 at 12 52 37 PM

Screenshot 2020-08-06 at 12 53 44 PM

@SathyaJayabal SathyaJayabal added Challenge Listing P2 Important (resolve within 3 days) Beta Env Environment v5-intgration-sub-code labels Aug 6, 2020
@sushilshinde sushilshinde changed the title Sort by: Time to submit and Time to register does not work as expected [$50]Sort by: Time to submit and Time to register does not work as expected Aug 6, 2020
@crazyk07
Copy link

crazyk07 commented Aug 6, 2020

Contest https://www.topcoder.com/challenges/30136118 has been created for this ticket.

This is an automated message for crazyk via Topcoder X

@sushilshinde
Copy link
Collaborator

@topcoder-platform/topcodercompetitors @topcoder-platform/tcxcommunity this is open for pickup

Submit in 8 hours and PR to

https://github.com/topcoder-platform/community-app/tree/integration-v5-challenge-api
https://github.com/topcoder-platform/topcoder-react-lib/tree/integration-v5-challenge-api

run npm run test before PR

@crazyk07
Copy link

crazyk07 commented Aug 6, 2020

Contest https://www.topcoder.com/challenges/30136118 has been updated - it has been assigned to Narekvar90.

This is an automated message for crazyk via Topcoder X

@narekcat narekcat removed their assignment Aug 6, 2020
@cagdas001 cagdas001 self-assigned this Aug 6, 2020
@crazyk07
Copy link

crazyk07 commented Aug 6, 2020

Contest https://www.topcoder.com/challenges/30136118 has been updated - it has been assigned to cagdas001.

This is an automated message for crazyk via Topcoder X

cagdas001 added a commit to cagdas001/community-app that referenced this issue Aug 7, 2020
Fix/rewrite TIME_TO_REGISTER and TIME_TO_SUBMIT sorting functions.

Addresses topcoder-platform#4715
@cagdas001
Copy link
Collaborator

PR: #4725

It will first sort the upcoming challenges (i.e. you have still time to submit/register), by ascending order. Then sort the past challenges (i.e. submission/registration phase is in past) in the descending order.

For e.g., you'll see a sorting like this
Challenge A (3 days to submit)
Challenge B (5 days to submit)
Challenge C (submission phase ended 3 days ago)
Challenge D (submission phase ended 5 days ago)

@SathyaJayabal
Copy link
Collaborator Author

SathyaJayabal commented Aug 10, 2020

My Challenges bucket: Time to Submit
Open for registration bucket: Time to Submit
works as expected.

Open for registration bucket: Time to Register sort is not fixed
Screenshot 2020-08-10 at 12 06 20 PM

@SathyaJayabal SathyaJayabal added QA Fail QA verification on Dev has failed. Assignee to redo the fix. and removed Merged for QA Ready for QA QA Fail QA verification on Dev has failed. Assignee to redo the fix. labels Aug 10, 2020
@sushilshinde
Copy link
Collaborator

Thanks, some technicical problem with the staging environemnts PR so not merged.

@sushilshinde
Copy link
Collaborator

@cagdas001 Can you fix tests?

@cagdas001
Copy link
Collaborator

@cagdas001 Can you fix tests?

@sushilshinde done

@lakshmiathreya
Copy link

@SathyaJayabal pls review. My Challenges Time to Submit sort listing is the same in Staging and Prod.
Screenshot 2020-08-21 at 12 12 01 PM
Screenshot 2020-08-21 at 12 12 13 PM

@lakshmiathreya lakshmiathreya added Need clarification Need clarification to proceed fixing the issue further and removed dependent-on-another-issue-fix labels Aug 21, 2020
@SathyaJayabal
Copy link
Collaborator Author

@cagdas001, for time to register sort (Open for registration bucket), the late challenges must be displayed first. But the late challenges are displayed in the end.
example:
Screenshot 2020-08-24 at 11 57 14 AM

Screenshot 2020-08-24 at 11 57 08 AM

@SathyaJayabal SathyaJayabal added tcx_Feedback and removed Need clarification Need clarification to proceed fixing the issue further Ready for QA tcx_ReadyForReview labels Aug 24, 2020
@cagdas001
Copy link
Collaborator

@SathyaJayabal Yes, because there is no possibility to register on late challenges, phase is already closed. So I thought it'd be better for user if we first show the challenges that has still time for registration/submission.

The current sorting is as follows:
#4715 (comment)

It will first sort the upcoming challenges (i.e. you have still time to submit/register), by ascending order. Then sort the past challenges (i.e. submission/registration phase is in past) in the descending order.

For e.g., you'll see a sorting like this
Challenge A (3 days to submit)
Challenge B (5 days to submit)
Challenge C (submission phase ended 3 days ago)
Challenge D (submission phase ended 5 days ago)

Do we need to show late challenges first?

@SathyaJayabal
Copy link
Collaborator Author

SathyaJayabal commented Aug 24, 2020

@cagdas001, You are right
@sushilshinde, can we go ahead with above implementation?

@SathyaJayabal
Copy link
Collaborator Author

verified on prod
Screenshot 2020-08-24 at 8 58 37 PM
Screenshot 2020-08-24 at 8 58 49 PM

Screenshot 2020-08-24 at 8 58 24 PM

@crazyk07
Copy link

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30136118

This is an automated message for crazyk via Topcoder X

@SathyaJayabal
Copy link
Collaborator Author

verified on prod
Screenshot 2020-08-24 at 9 01 11 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants